compiler: Minimize code size reusing efuncs as much as possible - #2979
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2979 +/- ##
==========================================
+ Coverage 83.57% 83.58% +0.01%
==========================================
Files 257 257
Lines 53783 53823 +40
Branches 4608 4609 +1
==========================================
+ Hits 44951 44990 +39
- Misses 8035 8036 +1
Partials 797 797
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
approved these changes
Jul 27, 2026
| CommCallable: 1 | ||
| } | ||
| return sorted_priority(efuncs, priority) | ||
| return sorted(efuncs, key=lambda i: natural_sort_key(i.name)) |
Contributor
There was a problem hiding this comment.
why i.name the natural_sort_key already calls .name
Contributor
Author
There was a problem hiding this comment.
r0, r1, r10, r11, ..., r2, r3, ..
instead we now do
r0, r1, r2, r3, ..., r10, r11, ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.