fix(scripts): fail the unit-test runner when the Gradle test task fails#192
Open
gmaclennan wants to merge 1 commit into
Open
fix(scripts): fail the unit-test runner when the Gradle test task fails#192gmaclennan wants to merge 1 commit into
gmaclennan wants to merge 1 commit into
Conversation
run_unit_tests swallowed any failure of :comapeo-core-react-native:test with a "module name may differ" warning, so --unit-only exited 0 even on a Kotlin compile error and stale test-results XML read as a pass. The module name is fixed by Expo autolinking in this repo, so the guard protects nothing; with set -e in effect, the bare invocation now aborts the run with a non-zero exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./scripts/run-instrumented-tests.sh --unit-onlyswallowed any failure of the library's Gradle test task behind a "module name may differ" warning, so the script exited 0 even when the Kotlin test sources failed to compile — and the previous run's stale test-results XML then read as a pass. This bit for real during the PR #111 review work: a missingassertTrueimport produced a green "JVM unit tests completed" run.The module name is fixed by Expo autolinking in this repo (
:comapeo-core-react-native), so the guard protected nothing. The script already runs underset -euo pipefail, so dropping the|| echomakes a test-task failure abort the run with a non-zero exit.The script is a local-dev convenience (CI invokes Gradle directly), so this only changes local behaviour.
Verified locally:
--unit-onlypasses on a clean tree; with an intentionally-broken test source the script now exits 1 at the Gradle step instead of printing the completion message.