TUI - enable segmented markdown rendering - #3851
Merged
Merged
Conversation
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
Lower-confidence findings (not posted inline)
- [low] pkg/tui/components/markdown/incremental.go:317 — renderPlainParagraph tail-render fallback leaves plainInputPrefix advanced while block-level state reflects full render (confidence: weak 52/100)
aheritier
added
area/tui
krissetto
force-pushed
the
tui-progressive-markdown
branch
from
July 27, 2026 15:11
b8e50ba to
48a26af
Compare
Sayt-0
previously approved these changes
Jul 27, 2026
krissetto
force-pushed
the
tui-progressive-markdown
branch
from
July 27, 2026 15:18
48a26af to
6f87fbb
Compare
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The segmented rendering design is sound and well-tested. One minor stats-accounting issue was found in the error-fallback path.
krissetto
force-pushed
the
tui-progressive-markdown
branch
from
July 27, 2026 15:55
6f87fbb to
6bec609
Compare
dgageot
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change lets streaming consumers receive Markdown output as two sections: completed top-level blocks that can be retained, and the trailing block that may still change as new text arrives.
The existing renderer already avoided reparsing completed blocks. This change will enable us to avoid repeatedly joining, scanning, splitting, and styling the full rendered response.
The renderer remains conservative around unfinished or context-sensitive Markdown, and tests compare every intermediate result with the result of rendering the complete accumulated response from scratch.
This PR enables a subsequent change, where transcript and viewport code retain the completed rendered lines and replace only the changing tail. It will not bring any noticeable performance improvements on its own