fix(plans): address review follow-ups from #3853 - #3865
Merged
Conversation
aheritier
reviewed
Jul 29, 2026
| task test | ||
| task test-binary | ||
|
|
||
| # Plan storage relies on OS-specific file locking and path semantics, so its |
Collaborator
There was a problem hiding this comment.
it's interesting @Sayt-0 as we said that we wanted to expand a bit our tests on windows to avoid some issues which were impacting only this OS. To see if we want to run only a few tests or all of them in the future
aheritier
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3853 that addresses review feedback around export safety, telemetry privacy, validation hooks, shared plan events, editor resolution, test placement, and Windows coverage.
Review feedback
windows-latestplan test job and made it gate image publicationcmd/rootandpkg/tuito the Windows cross-buildPreRunEhooks could be replaced--forceexplicitly enables atomic replacementpkg/tui/internal/editornameplan_detail.goplan_changedwas undocumentedValidation
task buildtask testtask test-binarytask linttask check-plan-crossgo test -race -count=1 ./pkg/plansDesign notes
plan_changedremains process-global because the shared notifier does not carry mutating-session identity and every open plans view must refresh. The API documentation now makes that visibility explicit.