Skip to content

fix(plans): address review follow-ups from #3853 - #3865

Merged
Sayt-0 merged 6 commits into
mainfrom
fix/plans-3853-review-followups
Jul 29, 2026
Merged

fix(plans): address review follow-ups from #3853#3865
Sayt-0 merged 6 commits into
mainfrom
fix/plans-3853-review-followups

Conversation

@Sayt-0

@Sayt-0 Sayt-0 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #3853 that addresses review feedback around export safety, telemetry privacy, validation hooks, shared plan events, editor resolution, test placement, and Windows coverage.

Review feedback

Review point Resolution
Windows locking was compile-only Added a native windows-latest plan test job and made it gate image publication
Windows caller coverage was incomplete Added cmd/root and pkg/tui to the Windows cross-build
Plans telemetry included user values Limited telemetry to the subcommand and stable error codes
Existing PreRunE hooks could be replaced Chained the existing hook and added regression tests
CLI export overwrite behavior was ambiguous Existing destinations are refused by default; --force explicitly enables atomic replacement
Editor launch resolution was duplicated Centralized command construction in pkg/tui/internal/editorname
Plan detail tests were hard to discover Moved them alongside plan_detail.go
plan_changed was undocumented Documented its payload and process-global visibility

Validation

Check Result
task build pass
task test pass
task test-binary pass
task lint pass
task check-plan-cross pass
go test -race -count=1 ./pkg/plans pass
Workflow and documentation lint pass
Native Windows plan tests pending PR CI

Design notes

  • Non-force export uses atomic hard-link publication after fully writing, syncing, closing, and securing a temporary file. Filesystems without hard-link support return a typed storage error rather than weakening the no-overwrite guarantee.
  • plan_changed remains process-global because the shared notifier does not carry mutating-session identity and every open plans view must refresh. The API documentation now makes that visibility explicit.

@Sayt-0
Sayt-0 requested a review from a team as a code owner July 29, 2026 09:32
@aheritier aheritier added area/ci CI/CD workflows and pipeline area/core Core agent runtime, session management area/docs Documentation changes area/runtime Runtime engine, agent loop execution, tool dispatch, loop detection area/testing Test infrastructure, CI/CD, test runners, evaluation area/tui For features/issues/fixes related to the TUI kind/fix PR fixes a bug (maps to fix:). Use on PRs only. labels Jul 29, 2026
Comment thread .github/workflows/ci.yml
task test
task test-binary

# Plan storage relies on OS-specific file locking and path semantics, so its

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's interesting @Sayt-0 as we said that we wanted to expand a bit our tests on windows to avoid some issues which were impacting only this OS. To see if we want to run only a few tests or all of them in the future

@Sayt-0
Sayt-0 merged commit 057a4b1 into main Jul 29, 2026
20 checks passed
@Sayt-0
Sayt-0 deleted the fix/plans-3853-review-followups branch July 29, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI/CD workflows and pipeline area/core Core agent runtime, session management area/docs Documentation changes area/runtime Runtime engine, agent loop execution, tool dispatch, loop detection area/testing Test infrastructure, CI/CD, test runners, evaluation area/tui For features/issues/fixes related to the TUI kind/fix PR fixes a bug (maps to fix:). Use on PRs only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants