engine/daemon: Document embedded containerd mode - #25658
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The new embedded-containerd.md page is well-structured: front matter is complete (title, description, keywords, linkTitle, weight), callout syntax is correct, no hedge words, no 'allows/enables you to' constructions, no bold misuse, no broken code blocks. One minor path-style note is left inline.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The new embedded-containerd.md page is well-structured, technically clear, and follows Docker documentation conventions. No high or medium severity issues were found.
What looks good:
- Front matter is complete (
title,description,keywords,linkTitle,weight) - Callout types are appropriate:
CAUTIONfor experimental status,IMPORTANTfor state-path warning,WARNINGfor the debugging caveat - Code blocks use
consolewith$prompt for shell commands; JSON block usesjsonhint - No hedge words ("simply", "just", "easily") or AI-isms detected
- The CAUTION callout correctly surfaces the experimental status upfront
- The
ctrexample is specific and accurate for the documented endpoint path - Link to
_index.md#configuration-fileanchors correctly to the### Configuration fileheading
Minor observations (no action required):
- The page could optionally carry a sidebar badge (
color: violet, text: Experimental) in front matter to surface the experimental status in navigation before readers open the page — but the CAUTION callout covers this inline - The Windows note ("Check the Docker daemon startup logs for the endpoint address") is intentionally brief; an example named-pipe format could help Windows users, but this is optional given the feature is experimental
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
One low-severity style suggestion (passive voice) in the new page. Content is accurate, front matter is complete, callouts are appropriate, and commands match the described behavior.
Explain how Engine 29.7.0 can run containerd inside dockerd, how to enable and verify the experimental mode, and how external clients can connect to its endpoint. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2c38306 to
7a3efe1
Compare
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The new page is well-structured, accurate, and follows Docker documentation conventions. Front matter is complete (title, linkTitle, description, keywords, weight). Callout syntax is correct. Code blocks use appropriate language hints. No style violations found (no hedge words, no "allows you to"/"enables you to", no "we", no "click"). The bullet link is properly formatted.
2 participants
Description
Explain how Engine 29.7.0 can run containerd inside dockerd, how to enable and verify the experimental mode, and how external clients can connect to its endpoint.
Related issues or tickets
Reviews