Use AsyncTask thread-safe logging in GetMicrosoftNuGetPackagesMap#11948
Open
jonathanpeppers with Copilot wants to merge 2 commits into
Open
Use AsyncTask thread-safe logging in GetMicrosoftNuGetPackagesMap#11948jonathanpeppers with Copilot wants to merge 2 commits into
jonathanpeppers with Copilot wants to merge 2 commits into
Conversation
5 tasks
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix usage of obsolete Log property in GetMicrosoftNuGetPackagesMap
Use AsyncTask thread-safe logging in GetMicrosoftNuGetPackagesMap
Jul 2, 2026
jonathanpeppers
approved these changes
Jul 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GetMicrosoftNuGetPackagesMap MSBuild task to use AsyncTask’s thread-safe logging helper while running on the background execution path, avoiding the obsolete Log property usage.
Changes:
- Replaced
Log.LogMessage (...)with the inheritedLogMessage (...)call insideRunTaskAsync ()’s exception handler. - Removed an extraneous trailing blank line at the end of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetMicrosoftNuGetPackagesMapruns onAsyncTask's background execution path but still logged through the obsoleteLogproperty. This updates the task to use the thread-safe logging helper intended forAsyncTaskimplementations.Logging path
Log.LogMessage (...)call inGetMicrosoftNuGetPackagesMap.RunTaskAsync ()with the inheritedLogMessage (...)helper.Scope
GetMicrosoftNuGetPackagesMap.cs.