Adopt ordered multi-caret markers in FCS tests (no behaviour change) - #20082
Open
T-Gro wants to merge 5 commits into
Open
Adopt ordered multi-caret markers in FCS tests (no behaviour change)#20082T-Gro wants to merge 5 commits into
T-Gro wants to merge 5 commits into
Conversation
…anchor comments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9d20cd22-45dc-411f-9163-185fd6dd54d9
Uses SourceContext.extractOrderedMarkedSources (multi-caret) to replace whole-source [<Theory>] copies with one marked source in DotOff.ArraySliceNotation (3 copies) and CurriedArguments.Regression (5 copies). No behaviour change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9d20cd22-45dc-411f-9163-185fd6dd54d9
Contributor
|
Bug312557_2 (4 source copies -> 1 {caretN}) and Bug69673_1.CtrlSpaceForThis
(2-row Theory -> 1). No behaviour change.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9d20cd22-45dc-411f-9163-185fd6dd54d9
…caretN}
The 8 Facts shared an identical source copied per caret; now one {caret1..8}
source + a (field-name, range) cases list. No behaviour change.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9d20cd22-45dc-411f-9163-185fd6dd54d9
…source
Replaces magic ((line,col),(line,col)) tuples with {selstart}/{selend} markers
around the breakpoint span; the validation caret is inferred from {selend}
(SourceContext), so no {caret} needed. Compares against context.SelectedRange.
No behaviour change (all 6 tests green).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9d20cd22-45dc-411f-9163-185fd6dd54d9
T-Gro
force-pushed
the
tests/adopt-ordered-carets
branch
from
July 24, 2026 13:46
54ac48a to
b8c97d2
Compare
T-Gro
marked this pull request as ready for review
July 24, 2026 13:49
T-Gro
added
the
NO_RELEASE_NOTES
github-actions
Bot
added
AI-Tooling-Check-Bypassed
Member
Should we convert them all, so more tests could use the same infrastructure and the extra helpers could be removed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20033, building on @auduchinok's #20077. Adopts the ordered multi-caret / selection markers (
SourceContext.extractOrderedMarkedSources+{selstart}/{selend}) to remove copy-pasted test sources and magic coordinates.No behaviour change — every migrated test keeps identical assertions (each commit rubber-duck-verified byte-for-byte; tests green on net472 + net10.0).
Reductions:
open System+ now-redundant caret-anchor(*loc-N*)commentsArraySliceNotation(3 source copies → 1),CurriedArguments(5 → 1),Bug312557_2(4 → 1),Bug69673_1(2 → 1)Nested copy-and-update(8 Facts sharing a copied source → 1)((line,col),(line,col))tuples →{selstart}/{selend}markers in the sourceDeliberately not migrated (it would make the code worse, not better):
markAtStartOfMarker/markAtEndOfMarkeron a shared source — they already reuse the source, with heterogeneous asserts per position;{caretN}there is 0 reduction and messier.$/ direct-column low-level marker tests (IdentifierIsland, QuickParse, …) —$is more compact than{caret}; migrating adds indirection + a ±1 column risk for no reduction.