Fix release notes check for fork pull requests - #20091
Draft
abonie wants to merge 1 commit into
Draft
Conversation
check_release_notes runs on pull_request_target and used actions/checkout to pull the PR's head ref. Now that checkout refuses fork checkouts under pull_request_target, every fork PR failed the check. It no longer checks out fork code: the files it needs are fetched through the GitHub Contents API and only ever grepped, so the check works for fork PRs without putting untrusted code in a job that holds the base repo's token. NO_RELEASE_NOTES now short-circuits before anything is fetched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee911491-8b95-4ae6-9155-d476c5a83f67
abonie
added
the
NO_RELEASE_NOTES
github-actions
Bot
added
the
⚠️ Affects-Build-Infra
This comment has been minimized.
This comment has been minimized.
Contributor
|
🔍 Tooling Safety Check — Affects-Build-Infra
|
abonie
marked this pull request as draft
July 29, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_release_notesruns onpull_request_targetand usedactions/checkoutto pull the PR's head ref. Now that checkout refuses fork checkouts underpull_request_target, every fork PR failed the check.It no longer checks out fork code: the files it needs are fetched through the GitHub Contents API and only ever grepped, so the check works for fork PRs without putting untrusted code in a job that holds the base repo's token.
NO_RELEASE_NOTESnow short-circuits before anything is fetched.