[msbuild] Avoid concurrent Errors.designer.cs generation. Fixes #26246 - #26258
[msbuild] Avoid concurrent Errors.designer.cs generation. Fixes #26246#26258rolfbjarne wants to merge 2 commits into
Conversation
Generate the strongly typed resource source in each target framework's intermediate output directory so parallel builds never write the same file.\n\nFixes #26246\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: 11fcec85-a3d3-45d6-a14f-78e6fd6976e0
Fix the grammar in the updated explanation of the generated resource isolation. Fixes #26246 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11fcec85-a3d3-45d6-a14f-78e6fd6976e0
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Updates the MSBuild project for Xamarin.MacDev.Tasks to stop generating Errors.designer.cs into the source tree and instead emit it into each target framework’s intermediate output directory, preventing intermittent file corruption when builds run in parallel (as seen in #26246).
Changes:
- Generate the strongly-typed resource source (
Errors.designer.cs) under$(IntermediateOutputPath)instead of the project directory. - Clarify the inline project comment explaining why the file is generated separately and why per-TFM intermediate output matters.
- Minor comment text cleanup/typo fix (“build” → “built”).
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #fcf6d74] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 203 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Generate Xamarin.MacDev.Tasks' strongly typed resource source in each target framework's intermediate output directory.
This prevents parallel builds from writing to the same source-tree Errors.designer.cs file and intermittently corrupting it.
Fixes #26246
🤖 Pull request created by Copilot