Qualify signed worker launch and broker boundary#51
Merged
Conversation
Repair AppContainer package read/execute access with reversible per-profile ACLs, make worker startup broker reads deterministic, constrain Pillow codec loading, and add a disposable signed end-to-end qualification gate. Document the live evidence and keep the provider transform release gate blocked on timeout.
Owner
Author
|
Remote verification complete: GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR advances the signed worker release gate and fixes the packaged-worker startup failure shown in the reported PyInstaller
PKG archivedialog.What changed
CreateProcessW, then revoke that per-launch ACE during cleanup.tools/execution_spikes/recipe_worker_e2e_qualification.py, a disposable signed end-to-end gate covering:prepare,input_chunk,input_complete, andcollectprotocol stages;C:\Windows\System32.Root cause and current gate
The reported embedded-PKG error was caused by the fresh AppContainer having no read/execute permission on the user-owned temporary package tree. That launch precondition is repaired and live-qualified.
The qualification run now passes signed installation, provenance, AppContainer/job identity binding, broker handshake,
prepare, andinput_chunk. It intentionally blocks atinput_completewithworker_response_timeoutwhile the packaged provider transform remains inside the worker. This PR therefore does not enable production provider execution or close the OS/provider lifecycle release gate.Validation
python -m pytest -q— 259 passed, 1 expected platform skip.py_compile,compileall, andgit diff --checkpassed.packaging/build_recipe_worker.ps1— PyInstaller one-folder build completed successfully.input_chunk, fail-closed timeout atinput_complete; no worker process remained after cleanup.Risk and rollout
No application lifecycle or provider enablement is changed. The qualification helper is not imported by Cortex, accepts no user/model input, uses only an in-memory trust root, and cannot turn a timeout into a pass. The remaining provider-transform timeout is documented as a blocking release condition for the next stage.