Fix packaged worker native broker read starvation#52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PeekNamedPipewith a bounded 5 ms wait before synchronousReadFilecalls.Root cause
The worker starts a broker reader thread so cancellation frames remain live while Pillow transforms. A blocking synchronous native read could starve the packaged transform thread under the AppContainer, so the request stopped at
input_completeeven though the provider and transport contracts were otherwise valid. Availability polling keeps the reader responsive without changing framing, authentication, direction, or sequence validation; pipe errors still fail closed.Validation
python -m pytest -q— 260 passed, 1 skipped.python -m pytest tests/test_phase2_native_broker.py -q— 10 passed, 1 skipped.python -m compileall -q backend\\cortex_backend\\execution tests.git diff --check.packaging/build_recipe_worker.ps1build.prepare,input_chunk,input_complete, andcollect_output; bounded cleanup left no worker process.Release-gate status
This closes the packaged provider-transform qualification blocker. Phase 2 remains blocked on dedicated signed-worker watchdog/cancellation and hostile-decoder corpus evidence, external security review, and production lifecycle wiring. No production provider launch is enabled by this PR.