Qt-removal R7.4b: Ollama settings page (backend+frontend)#145
Merged
Conversation
Closes the second of R2.5d's 3 deferred settings pages: reasoning mode, per-task model assignment (auto/inherit/explicit), real system model scan, and real model pull, all wired through 4 new backend/settings.py intents and a new OllamaPage/OllamaTaskField pair in SettingsDialog.tsx. Proactively applies the R7.4a "fix classes not instances" lesson at design time: every intent argument is coerced before use, every read-modify-write happens inside one locked closure, and the reasoning- mode live-reapply collapses its check-then-act into a single hop so a concurrent provider switch can't be clobbered back to Ollama. A 4-way adversarial review (backend/frontend/integration/legacy-parity) found and fixed 3 real issues: a stranded reentrancy gate on a scan/pull persistence failure, a missing task_chat + "inherit" normalization gap, and a misleading legacy-parity comment (the reasoning-mode live-reapply is actually a fix for a real legacy staleness bug, not a port of existing behavior). All fixes mutation-tested against reverted code. Verified with a live WS drive against a real backend with a real running Ollama server (10 real models scanned, a real pull succeeded) using an isolated scratch settings file - the real ~/.graphlink/session.dat confirmed byte-identical before and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend/settings.pyintents + a newOllamaPage/OllamaTaskFieldpair inSettingsDialog.tsx.task_chat+"inherit"normalization gap, and a misleading legacy-parity comment (the reasoning-mode live-reapply is actually a fix for a real legacy staleness bug, not a port of existing behavior). All fixes mutation-tested against reverted code.Test plan
python -m compileall -q .cleantests/test_no_qt_anywhere.py) unchanged: 152/84/68npm run check(schema-check/tsc/eslint/vitest/build): 1081 vitest passed, 0 lint errors, build clean~/.graphlink/session.datconfirmed byte-identical before and after