Add upper-bound chunk-size validation to put#295
Merged
Conversation
Reject chunk sizes below 4MiB, not a multiple of 4MiB, or above 128MiB with distinct error messages. Previously only the modulo check existed, silently allowing values that exceed Dropbox upload-session limits. Update flag descriptions, examples, and generated docs to document the constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--chunksizevalues below 4MiB or above 128MiB with distinct error messages, in addition to the existing multiple-of-4MiB check.putChunkSizeUnitandputMaxChunkSizeconstants to replace inline magic numbers.--chunksizeand--workersto clarify they apply to chunked large-file uploads.Test plan
go test ./cmd/ -run TestPutChunkSizepasses all three casesgo build ./...succeedsgo run ./tools/gen-docsoutput matchesdocs/commands/dbxcli_put.md