build: pin the patched ANTLR generator jar, drop stale ANTLR remnants#1308
Open
joaodinissf wants to merge 1 commit into
Open
build: pin the patched ANTLR generator jar, drop stale ANTLR remnants#1308joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
joaodinissf
force-pushed
the
chore/remove-stale-readme
branch
2 times, most recently
from
9a5b925 to
dab42af
Compare
joaodinissf
force-pushed
the
chore/remove-stale-readme
branch
2 times, most recently
from
3f4c905 to
ebb9454
Compare
The MWE2 grammar workflows need the patched ANTLR 3.2 generator. The launch classpath of GenerateTestLanguage.mwe2.launch references com.avaloq.tools.ddk.workflow/antlr-generator-3.2.0-patch.jar, but the jar was never committed - Xtext's AntlrToolFacade silently downloads it (without checksum verification) from itemis hosting that has already moved once and whose p2 repository is dead. Commit the jar (SHA-256 pinned in the accompanying note) so regeneration is self-contained. Also remove two stale remnants of the manual-download era: ddk-parent/readme.txt (instructed downloading the wrong jar into a folder no resolution route reads) and ddk-target/ddk-antlr.target (orphaned target definition referencing the dead itemis p2 repository; no references anywhere in the repo). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/remove-stale-readme
branch
from
ebb9454 to
bb0c518
Compare
joaodinissf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the ANTLR generator dependency self-contained and removes two stale remnants of the manual-download era.
Pin the generator jar
The MWE2 grammar workflows need the patched ANTLR 3.2 generator.
GenerateTestLanguage.mwe2.launchalready referencescom.avaloq.tools.ddk.workflow/antlr-generator-3.2.0-patch.jaron its classpath — but the jar was never committed. In its absence, Xtext'sAntlrToolFacadesilently downloads it, without checksum verification, from itemis hosting that has already moved once (download.itemis.com→artifacts.itemis.cloud) and whose p2 repository is dead (HTTP 404). If that URL ever disappears, no DDK grammar can be regenerated from a fresh clone.The jar is now committed (1.4 MB, frozen upstream since 2014, BSD-licensed) with its provenance and SHA-256 recorded in
antlr-generator-3.2.0-patch.mdalongside. The bytes were verified against the URL the Xtext 2.43 sources actually use. Theworkflowproject is not a Maven module, so this has no build impact; the jar matters only for IDE-based grammar regeneration.GenerateCheck/GenerateCheckCfglaunch configs use Eclipse's default classpath and keep the auto-download fallback (cached as a gitignored hidden file); the note documents this. The jar becomes deletable if generation ever moves toxtext-maven-plugin+org.eclipse.xtext:xtext-antlr-generatorfrom Maven Central.Remove stale remnants
ddk-parent/readme.txt— "Download antlr-generator-3.2.0.jar into this folder": names the unpatched jar and a location that no resolution route (classpath, working directory, download cache) ever reads. Nothing references it.ddk-target/ddk-antlr.target— orphaned target definition whose primary location is the dead itemis p2 repository, pinning 2022-era Eclipse/SWTBot/Orbit URLs that contradict the maintainedddk.target. Zero references anywhere in the repo; not wired into the Maven/Tycho build.🤖 Generated with Claude Code