fix: minor robustness/logging cleanups from the inconsistency sweep#1394
Open
joaodinissf wants to merge 1 commit into
Open
fix: minor robustness/logging cleanups from the inconsistency sweep#1394joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
- ScopeResourceDescriptionStrategy.getSourceText: guard a null parse result before dereferencing getRootNode() (resources without a node model exist, e.g. direct-linking storage), returning "" as for the proxy case. - CustomClassAwareEcoreGenerator: non-OK EMF generation diagnostics were logged at INFO, so warnings/errors were easy to miss; log them at WARN. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
fix/sweep-minor-robustness
branch
from
f4b5fb7 to
2367166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two low-risk cleanups from the repo-wide inconsistency sweep (bundled as one small PR):
ScopeResourceDescriptionStrategy.getSourceText— guard a nullgetParseResult()beforegetRootNode()(node-model-less resources exist, e.g. direct-linking storage), returning""as it already does for the proxy case. Without the guard the NPE is swallowed by the enclosingcatch (RuntimeException)and the scope model is silently not indexed at all; with it, the model is indexed with the source text contributing as empty.CustomClassAwareEcoreGenerator— non-OK EMF generation diagnostics were logged atINFO, so warnings/errors were easy to miss; log them atWARN.🤖 Generated with Claude Code