fix: remove duplicate spotbugs <maxHeap> (resurrect spotbugs.maxHeap=2048)#1398
Open
joaodinissf wants to merge 1 commit into
Open
fix: remove duplicate spotbugs <maxHeap> (resurrect spotbugs.maxHeap=2048)#1398joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
joaodinissf
force-pushed
the
ci/spotbugs-maxheap-dedupe
branch
from
2bedac6 to
4d96415
Compare
…2048)
The spotbugs-maven-plugin <configuration> declared <maxHeap> twice: first
${spotbugs.maxHeap} (2048), then a hardcoded <maxHeap>1024</maxHeap> that
silently overrode it — so the spotbugs.maxHeap property was dead and the
effective per-analysis (forked) heap was 1 GB, not the intended 2 GB. Remove
the stray override so the property takes effect.
Note on memory headroom: under -T 2C a full scan can run up to ~8 forks
concurrently (~8x2G plus ~4G for Maven exceeds a 16G runner). If the
full-scan spotbugs job ever OOMs, lower spotbugs.maxHeap or the reactor
thread count.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
ci/spotbugs-maxheap-dedupe
branch
from
4d96415 to
f662c60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
spotbugs-maven-plugin<configuration>declared<maxHeap>twice —${spotbugs.maxHeap}(2048) then a hardcoded1024that silently overrode it. Sospotbugs.maxHeap=2048was dead and the effective per-analysis (forked) heap was 1 GB. This removes the stray<maxHeap>1024>so the property takes effect (2 GB).Note
Under
-T 2Ca full scan can run ~8 spotbugs forks concurrently (~8×2 GB + 4 GB maven ≈ 20 GB > the 16 GB runner). If the full-scan spotbugs job OOMs, lowerspotbugs.maxHeapor the reactor thread count (inline comment added).Independent of the CI-shape / SpotBugs-scoping work.
🤖 Generated with Claude Code