style: collapse verbose string building in pre-existing classes#1412
Open
joaodinissf wants to merge 1 commit into
Open
style: collapse verbose string building in pre-existing classes#1412joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
Behavior-identical readability tidy-ups: StringBuilder chains become plain concatenation or formatted strings, manual join loops become joins, redundant field initializers and length checks are dropped. No logic changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior-identical readability tidy-ups across 14 pre-existing Java classes — mostly collapsing
StringBuilderchains intoString()methods into plain concatenation or formatted strings, folding manual join loops into joins, and dropping redundant boolean field initializers and length checks. No logic changes anywhere.These changes were flagged in #1274 review as unrelated to the Xtend migration (correctly so) and are proposed here on their own so they can be judged on their own merits.
Verified with a full
mvn verifyincluding Checkstyle and PMD: clean.🤖 Generated with Claude Code