chore: emit LF from MWE2 code generation#1413
Open
joaodinissf wants to merge 1 commit into
Open
Conversation
All seven workflows requested "\r\n" while the repository stores and checks out LF everywhere (.gitattributes, line-endings CI check), so every regeneration wrote files that disagreed byte-wise with the checkout. Flip the lineDelimiter settings and the line.separator preference that ddk-configuration links into the other projects' .settings. Also set preferXtendStubs = false for the FormatterTestLanguage workflow: its stub classes exist as handwritten .java files, and with the default the generator's exact-path existence check misses them and resurrects .xtend duplicates that were deliberately removed in 2024. No regeneration is included: the committed src-gen is already pure LF in the index, so this only changes what future regenerations emit. Refs dsldevkit#1345. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns code generation with the repository's line-ending policy (
.gitattributes* text=auto eol=lf+ the line-endings CI check). Nine lines, no regeneration. Refs #1345.What changes
lineDelimiter = "\n"in all seven MWE2 workflows (was"\r\n"). Regeneratedsrc-genthen matches the checkout byte-for-byte instead of relying on git's index normalization to hide the difference.line.separator=\ninddk-configuration/.settings/org.eclipse.core.runtime.prefs. This file is not project-local config: 56 of the 64com.avaloq.tools.ddk*projects link it into their own.settingsvia.projectlinkedResources, so it governs what Eclipse writes across essentially the whole workspace.preferXtendStubs = falsefor the FormatterTestLanguage workflow only: its stub classes exist as handwritten.javafiles inxtext.test, and the generator's stub-existence check is exact-path/exact-flavor — with the default it misses the.javatwins and resurrects.xtendduplicates that were deliberately deleted in 2024. The other workflows keep the default, which is load-bearing for the format bundle's handwritten.xtendstubs.What deliberately does not change
src-genis already pure LF in the index (git ls-files --eolshows zero CRLF), so nothing needs rewriting; pending upstream codegen drift (Xtext 2.43 Activator/manifest changes) lands whenever a grammar is next regenerated for a real reason.LfNormalizingFileSystemAccessstays. Its retirement is a runtime-output question independent of these settings and is folded into the upcomingcheck.coreXtend→Java migration, where the generator templates become deterministic anyway.🤖 Generated with Claude Code