Trace quick access table disposal

[trancexpress]

Tracing for fail in QuickAccessDialogTest hints at a disposed table prior to updating entries in the table. This change adds tracing for table dispose to validate this.

See: #4009

[github-actions]

Test Results

   861 files  ± 0     861 suites  ±0   45m 40s ⏱️ - 12m 28s
 8 034 tests ± 0   7 789 ✅  -  2  243 💤 ± 0  2 ❌ +2 
20 451 runs   - 90  19 817 ✅  - 69  632 💤  - 23  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 23fb09d. ± Comparison against base commit 968d4ce.

♻️ This comment has been updated with latest results.

[trancexpress]

The tests in QuickAccessDialogTest seem to be failing a lot with this change... I'm not sure why. All the fails are on MacOS, similar to #4009...

Unfortunately the new tracing is hard to use, without knowing which test is running (still no clue where the workspace logs are for GH jobs)...

[trancexpress]

Seems like some of the job done notifications arrive when the test is already in {{tearDown()}}:

2026-06-12T08:13:01.2800940Z org.eclipse.ui.tests.UiTestSuite.testTextFilter -- Time elapsed: 11.37 s <<< FAILURE!
2026-06-12T08:13:01.2801620Z org.opentest4j.AssertionFailedError: The quick access items should have changed ==> expected: <true> but was: <false>
2026-06-12T08:13:01.2802440Z 	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
2026-06-12T08:13:01.2803250Z 	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
2026-06-12T08:13:01.2804240Z 	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
2026-06-12T08:13:01.2804930Z 	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
2026-06-12T08:13:01.2805880Z 	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
2026-06-12T08:13:01.2806710Z 	at org.eclipse.ui.tests.quickaccess.QuickAccessDialogTest.testTextFilter(QuickAccessDialogTest.java:167)
2026-06-12T08:13:01.2807590Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
2026-06-12T08:13:01.2809620Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
2026-06-12T08:13:01.2810980Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

Which is this code:

		text.setText("B"); // The letter mustn't be part of the previous 1st proposal
		assertTrue(DisplayHelper.waitForCondition(table.getDisplay(),
				TIMEOUT,
				() -> table.getItemCount() > 1 && !table.getItem(0).getText(1).equals(oldFirstItemText)),
				"The quick access items should have changed");

In the standard out I see:

2026-06-12T08:10:21.3756930Z testTextFilter(): tearDown...
2026-06-12T08:10:21.3757670Z 
2026-06-12T08:10:22.1091950Z org.eclipse.ui.internal.quickaccess.QuickAccessContents >>>  | Thread[#160,Worker-19: ⏳ Computing proposals for 'B',5,main] | Computed entries: [org.eclipse.ui.views.BookmarkView, org.eclipse.debug.ui.BreakpointView, org.eclipse.ui.tests.propertysheet.AdaptingSaveableView, org.eclipse.ui.tests.manual.SaveablesView, org.eclipse.debug.ui.DebugView, org.eclipse.debug.ui.DebugPerspective, org.eclipse.team.ui.TeamSynchronizingPerspective, org.eclipse.ui.tests.api.PerspectiveViewsBug88345, org.eclipse.ui.tests.OnboardingPerspective, org.eclipse.ui.project.buildAutomatically, org.eclipse.ui.help.aboutAction, org.eclipse.ui.file.closePart, org.eclipse.ui.window.closePerspective(org.eclipse.ui.window.closePerspective.perspectiveId=org.eclipse.debug.ui.DebugPerspective), buildAutomatically, org.eclipse.ui.actions.showKeyAssistHandler, org.eclipse.ui.tests.manual.BrokenUpdatePreferencePage, org.eclipse.ui.preferencePages.BuildOrder, org.eclipse.ui.internal.console.ansi.preferences.AnsiConsolePreferencePage, org.eclipse.ui.editors.preferencePages.Accessibility, search.in.help]
2026-06-12T08:10:22.1124620Z org.eclipse.ui.internal.quickaccess.QuickAccessContents >>>  | Thread[#160,Worker-19: ⏳ Computing proposals for 'B',5,main] | Compute entries Job result: Status OK: unknown code=0 OK, Job: ⏳ Computing proposals for 'B'(4025), last proposals Job: ⏳ Computing proposals for 'B'(4025), entries: [org.eclipse.ui.views.BookmarkView, org.eclipse.debug.ui.BreakpointView, org.eclipse.ui.tests.propertysheet.AdaptingSaveableView, org.eclipse.ui.tests.manual.SaveablesView, org.eclipse.debug.ui.DebugView, org.eclipse.debug.ui.DebugPerspective, org.eclipse.team.ui.TeamSynchronizingPerspective, org.eclipse.ui.tests.api.PerspectiveViewsBug88345, org.eclipse.ui.tests.OnboardingPerspective, org.eclipse.ui.project.buildAutomatically, org.eclipse.ui.help.aboutAction, org.eclipse.ui.file.closePart, org.eclipse.ui.window.closePerspective(org.eclipse.ui.window.closePerspective.perspectiveId=org.eclipse.debug.ui.DebugPerspective), buildAutomatically, org.eclipse.ui.actions.showKeyAssistHandler, org.eclipse.ui.tests.manual.BrokenUpdatePreferencePage, org.eclipse.ui.preferencePages.BuildOrder, org.eclipse.ui.internal.console.ansi.preferences.AnsiConsolePreferencePage, org.eclipse.ui.editors.preferencePages.Accessibility, search.in.help]

This seems odd, since the test waited for ~10 seconds for those computations... Here are the 10 seconds:

2026-06-12T08:10:12.8238830Z org.eclipse.ui.internal.quickaccess.QuickAccessContents >>>  | Thread[#1,main,6,main] | Updating proposals with filter: "B"
2026-06-12T08:10:12.8240000Z org.eclipse.ui.internal.quickaccess.QuickAccessContents >>>  | Thread[#1,main,6,main] | Will compute proposals with Job: ⏳ Computing proposals for 'B'(4025)
2026-06-12T08:10:12.8240990Z org.eclipse.ui.internal.quickaccess.QuickAccessContents >>>  | Thread[#1,main,6,main] | Set last proposals Job: ⏳ Computing proposals for 'B'(4025)
2026-06-12T08:10:21.3427050Z org.eclipse.ui.internal.quickaccess.QuickAccessContents >>>  | Thread[#1,main,6,main] | Table disposed