Avoid access to default scope on read of configuration scope preference#4088
Open
HeikoKlare wants to merge 1 commit into
Open
Avoid access to default scope on read of configuration scope preference#4088HeikoKlare wants to merge 1 commit into
HeikoKlare wants to merge 1 commit into
Conversation
Contributor
Test Results 861 files ± 0 861 suites ±0 46m 36s ⏱️ + 1m 5s For more details on these failures, see this check. Results for commit aa88965. ± Comparison against base commit a4171b1. ♻️ This comment has been updated with latest results. |
The configuration scope preference for monitor-specific scaling is read at a point in time where the workspace location may not have been defined, so that the instance scope preferences cannot be accessed yet. Since some defaults initializers require access to the instance scope, the access to the configuration scope preference must avoid access to the default scope in case no explicit value is set for that preference yet. This change adapts the access to the monitor-specific scaling configuration scope preference to not access the default scope. Since there may be further preference defaults initializers out of our control that access instance scope preferences, just adapting those in the Platform would not be a sufficient solution alternative. Fixes eclipse-platform#4085
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configuration scope preference for monitor-specific scaling is read at a point in time where the workspace location may not have been defined, so that the instance scope preferences cannot be accessed yet. Since some defaults initializers require access to the instance scope, the access to the configuration scope preference must avoid access to the default scope in case no explicit value is set for that preference yet.
This change adapts the access to the monitor-specific scaling configuration scope preference to not access the default scope. Since there may be further preference defaults initializers out of our control that access instance scope preferences, just adapting those in the Platform would not be a sufficient solution alternative.
Fixes #4085