Improve console water mark error messages#2763
Merged
Merged
Conversation
elsazac
force-pushed
the
improveLogMessages
branch
from
7b6dfb1 to
a4580d7
Compare
Contributor
SougandhS
reviewed
Jun 11, 2026
elsazac
force-pushed
the
improveLogMessages
branch
4 times, most recently
from
5246f69 to
811d019
Compare
improved exception messages to show actual water mark values and added validation. Currently in propertyChange() the exception is ignored so log invalid preference changes with specific values for easier debugging. Fixes: eclipse-platform#1262
elsazac
force-pushed
the
improveLogMessages
branch
from
811d019 to
2edb713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves logging when invalid console water mark values are encountered. Previously, users would see an IllegalArgumentException with the message, High water mark must be greater than low water mark without any indication of the actual values that caused the failure. This change updates to include the configured high and low water mark values in the exception message thrown by
IOConsole.setWaterMarks. Also adds a warning with additional context in logs inProcessConsole.propertyChangewhen an invalid console buffer configuration is detected.contributes to: #1262