Classify new Contentstack content types in essc discovery#3621
Open
Mpdreamz wants to merge 1 commit into
Open
Conversation
Register newly-added Contentstack content types (blog_landing, tutorial, notebook, etc.) as intentionally blocked, and non-page component/taxonomy types (accordion_faq, tags_*, hero, etc.) as known non-pages. The `contentstack types` command now shows a per-type status and fails when it finds a type that isn't classified in any of the three registries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@Mpdreamz: just saw this from the Slack thread. I noticed a Can we also add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Contentstack is introducing new content types (blog_landing, tutorial, notebook, series, etc.) that aren't ready to appear in search yet, plus a long tail of reusable component/taxonomy types (hero, accordion_faq, tags_*, etc.) that will never represent a standalone page.
PageContentTypes.Allis an opt-in allow-list, so none of these are synced today — but the discovery command (essc contentstack types) had no way to distinguish "not yet classified" from "deliberately not a page," making it easy for a genuinely new page-worthy type to go unnoticed.What
PageContentTypes.Blockedfor content types intentionally excluded from sync for now (still being authored, not search-ready).PageContentTypes.KnownNonPagesfor component/taxonomy/config content types that are never expected to sync.contentstack typesnow renders aStatuscolumn per discovered type (synced/ignored/skipped/unregistered) and exits 1 if any discovered type isn't classified inAll,Blocked, orKnownNonPages, so newly-added Contentstack types can't silently go unclassified.SyncCommandis unchanged — it already only syncs types explicitly listed inPageContentTypes.All.