fix: stamper store was dirty#5515
Merged
Merged
Conversation
sbackend123
force-pushed
the
fix/stamper-store-was-dirty
branch
from
376c94f to
a1c7f72
Compare
acud
approved these changes
Jun 23, 2026
sbackend123
changed the title
gacevicljubisa
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Related to #5392
leveldbstore and InitStamperStore return dirty (true = unclean shutdown), but in node.go it was named wasClean and passed to NewService as if it meant a clean shutdown. As a result, recovery did not run after a crash and could run unnecessarily after a normal restart.
Fix: use consistent wasDirty semantics across the whole chain, with if wasDirty and no inversions.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure