Bound peak memory in pyrefly coverage with streaming collection#4012
Open
jorenham wants to merge 1 commit into
Open
Bound peak memory in pyrefly coverage with streaming collection#4012jorenham wants to merge 1 commit into
pyrefly coverage with streaming collection#4012jorenham wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
Author
|
windows CI failure seems unrelated (and flaky) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyrefly coverage {check, report}kept every module's bindings/answers/ASTs in memory all at once (Require::Everything). It now collects each module the moment it is solved, right before the run evicts it, so peakmemory holds only the solver's working set. Unlike the chunked collection approach from #4009, which increased runtime, this approach improves runtime, because by keeping everything in memory, it also recorded traces that were never read.
numpyscipy-stubs(debug build)
The measurements in #4009 differ in the "before" because those used an outdated numpy version and ran scipy-stubs without scipy having installed.
Fixes #3989 and supplants #4009
Test Plan
Regression test added, and verified that this did not change any of the results for scipy-stubs and numpy.