Handle import fixes for unimported directives#4044
Open
aodihis wants to merge 1 commit into
Open
Conversation
reveal_type and assert_type produce UnimportedDirective diagnostics, so the existing unknown-name import action path should also consider that error kind. This lets the normal export search produce typing imports for those directives and adds regression coverage for both names.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3859
The issue #3859 is caused by an unhandled
UnimportedDirectiveerror kind. If we look atpyrefly/lib/state/lsp.rs, Pyrefly only handled the import action for theUnknownNameerror kind.This PR updates the existing import quick-fix path so
UnimportedDirectiveis handled alongsideUnknownName.Test Plan
Added coverage for the scenario where unimported directives such as
reveal_typeandassert_typeshould produce an import quick fix fromtyping.