Fix TSP inferred returns for definition-site computed types#4045
Open
WilliamK112 wants to merge 1 commit into
Open
Fix TSP inferred returns for definition-site computed types#4045WilliamK112 wants to merge 1 commit into
WilliamK112 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4042.
Summary
returnTypeat definition sites.untyped-def-behavior = check-and-infer-return-type.Validation
cargo +stable-x86_64-pc-windows-gnu test -p pyrefly test_get_computed_type_definition_site_uses_inferred_return_type -- --nocapturecargo +stable-x86_64-pc-windows-gnu test -p pyrefly get_type_queriescargo +stable-x86_64-pc-windows-gnu test -p pyrefly tsp_interactioncargo +stable-x86_64-pc-windows-gnu fmt --all --checkgit diff --checkcargo +stable-x86_64-pc-windows-gnu test -p pyrefly test_shape_dsl_reports_multiple_errors -- --nocaptureI also attempted the full
cargo +stable-x86_64-pc-windows-gnu test -p pyreflysuite. It reached6188 passed, 1 failed; the only failure was the unrelatedtest::shape_dsl::test_shape_dsl_reports_multiple_errorsinternal watchdog timeout (Error: Test took too long (> 20s)) during the full parallel run. The same test passed when rerun directly, as shown above.