Check SQLAlchemy update values against mapped fields#4047
Open
WilliamK112 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
sqlalchemy.update(Model)...values(field=...)keyword arguments.values()keyword names againstMapped[...]fields on the model, and validate value types against the mapped instance attribute type..where(...).values(...)with a regression test for support sqlalchemy update values field check #4046.Closes #4046.
Validation:
cargo +stable-x86_64-pc-windows-gnu test -p pyrefly --lib test::descriptors(50 passed)sqlalchemy==2.0.41temp sample reports the expectedcredential_idtype error,nametype error, andmissing_fieldunknown-field errorcargo +stable-x86_64-pc-windows-gnu fmt --all --checkgit diff --checkcargo +stable-x86_64-pc-windows-gnu test -p pyrefly --libreached 6184 passed / 5 failed; the 5 failures were shape_dslTest took too long (> 20s)watchdog failures under the full-suite load, and each failed test passed when rerun individually