fix: use BigInteger for OAuthAccount.expires_at to avoid 32-bit overflow#27
Open
SAY-5 wants to merge 1 commit into
Open
fix: use BigInteger for OAuthAccount.expires_at to avoid 32-bit overflow#27SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
tapetersen
suggested changes
Jun 24, 2026
tapetersen
left a comment
tapetersen
left a comment
There was a problem hiding this comment.
I'm not a maintainer but while the change seems reasonable I'm not sure the test is.
| assert unknown_oauth_user is None | ||
|
|
||
|
|
||
| def test_oauth_account_expires_at_is_big_integer(): |
There was a problem hiding this comment.
This test does nothing more than double check a declaration. If a test is warranted it should verify it corrects the original issue, that it accepts dates beyond 2038
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some OAuth providers return
expires_atvalues beyond 2038 (e.g. ORCID sandbox returns 2043), which overflow a 32-bitINTEGERcolumn and cause the insert to fail. Switching the column toBigIntegerfixes this on PostgreSQL, MySQL/MariaDB, etc. while remaining a no-op for SQLite.Closes #1296