Fix Pod::Spell and scalar temporary weak references#869
Merged
Conversation
Match Perl's visible side effect of loading Encode when an :encoding(...) layer is applied. Pod::Spell relies on this after its wordlist is opened as UTF-8. Add a focused regression test for Encode::encode availability. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
Birth-track unbound scalar referents that have never occupied a lexical, closure, package root, or aggregate slot. This lets weakening the sole reference consume it immediately without a reachability walk. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
fglock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encode.pmwhen applying a PerlIO:encoding(...)layerPerlIO::encodingunit/refcount/weaken_edge_cases.tunchanged and fix its scalar-temporary weak-reference failureRoot causes
Pod::Wordlistopens its bundled wordlist with:encoding(UTF-8).Standard Perl loads
Encodewhile applying that layer, andPod::Spelllater calls
Encode::encode. PerlOnJava performed the charset conversiondirectly without loading
Encode, so the call was undefined.The added PerlIO unit test changed the local parallel shard layout and exposed
an existing failure in
unit/refcount/weaken_edge_cases.t: a weak reference toan otherwise-unbound scalar returned from a subroutine remained defined.
RuntimeScalar.createReference()now birth-tracks only referents with nolexical, closure, package-global, or aggregate owner.
WeakRefRegistrycantherefore clear that proven ephemeral referent directly, without walking the
live object graph.
Test plan
make— passes all unit-test shards./jperl src/test/resources/unit/refcount/weaken_edge_cases.t— 43/43 pass./jperl src/test/resources/unit/bless_existing_scalar_ref_destroy.t— 4/4 passprove src/test/resources/unit/perlio_encoding_loads_encode.t./jperl src/test/resources/unit/perlio_encoding_loads_encode.t./jcpan Pod::Spell— all 8 test files and 54 tests pass; install succeedsweakenoperations, five runs:fix mean 0.404s; clean parent mean 0.404s
Generated with Codex