feat: add FirebaseStorageUISwift product for Swift SPM clients#1351
Open
demolaf wants to merge 7 commits into
Open
feat: add FirebaseStorageUISwift product for Swift SPM clients#1351demolaf wants to merge 7 commits into
demolaf wants to merge 7 commits into
Conversation
…wift-typed API Adds a new `FirebaseStorageUISwift` SPM library product with a Swift-only target that provides properly-typed `sd_setImageWithStorageReference(_:)` overloads using `StorageReference` directly, so Swift SPM clients no longer need workarounds. Closes #1271
…on with defaults and simplify storageURL
…rebase Storage 9+
…nd update StorageViewController to use FirebaseStorageUISwift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1271
Swift SPM clients currently can't call
sd_setImage(with:)passing aStorageReference— the ObjC headers use@classforward declarations (required to fix the Clang scan-phase failure in #1350), which leavesStorageReferenceopaque to the Swift importer.This PR adds
FirebaseStorageUISwift, a new Swift-only SPM library product that bridges this gap by providing properly-typed Swift extensions onUIImageView.Also migrates
FirebaseUI-demo-swiftfrom CocoaPods to SPM and updatesStorageViewControllerto demonstrate the new API.New product
Add
FirebaseStorageUISwiftto your SPM dependencies andimport FirebaseStorageUISwift. This re-exports bothFirebaseStorageUIandFirebaseStorage, so no additional imports are needed.API Changes