add tests#8310
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Generated by 🚫 Danger |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
The public api surface has changed for the subproject ai-logic_firebase-ai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
| } | ||
| "kotlin.String" -> { | ||
| builder.addStatement("JsonSchema.string(").indent() | ||
| if (!guideValues.enumValues.isNullOrEmpty()) { |
There was a problem hiding this comment.
enforces the enum values. Without this, we might receive strings not in the enum list.
| assertEquals("STRING", titleProp.type) | ||
| assertEquals("recipe-title-format", titleProp.format) | ||
|
|
||
| // Check enum for difficulty (Kotlin Enum Class) |
There was a problem hiding this comment.
this tests fails if we remove the enforcement in SchemaSymbolProcessorVisitor
|
The public api surface has changed for the subproject ai-logic_firebase-ai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
2 participants
No description provided.