Skip to content

fix(firedata): ignore quota project on getTosStatus to prevent 403 - #10857

Merged
joehan merged 2 commits into
mainfrom
firedata-tos-fix
Jul 28, 2026
Merged

fix(firedata): ignore quota project on getTosStatus to prevent 403#10857
joehan merged 2 commits into
mainfrom
firedata-tos-fix

Conversation

@itsrakhil

@itsrakhil itsrakhil commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Sets ignoreQuotaProject to true to prevent setting default x-goog quota headers that result in a 403 error for TosStatus checks. Fixes b/536740497(buganizer link).

@itsrakhil
itsrakhil requested a review from joehan July 27, 2026 23:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the getTosStatus function in src/gcp/firedata.ts to use client.request with the ignoreQuotaProject option set to true instead of a simple client.get call. I have no feedback to provide as the changes are correct and there are no review comments.

@joehan
joehan enabled auto-merge (squash) July 28, 2026 16:55
@joehan
joehan merged commit 8a84259 into main Jul 28, 2026
52 of 53 checks passed
@joehan
joehan deleted the firedata-tos-fix branch July 28, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants