Skip to content

Add options to enable /dev/kfd on amdgpu#4053

Open
mrbojangles3 wants to merge 1 commit into
flatcar:mainfrom
mrbojangles3:add_amd_hsa
Open

Add options to enable /dev/kfd on amdgpu#4053
mrbojangles3 wants to merge 1 commit into
flatcar:mainfrom
mrbojangles3:add_amd_hsa

Conversation

@mrbojangles3

@mrbojangles3 mrbojangles3 commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add amdgpu /dev/kfd

The amdgpu driver has two parts, one part is for the video use case,/dev/dri/card0, the other is for the compute use case,/dev/kfd. AMD has some documentation on it.

Currently the amdgpu driver is only exposing the /dev/dri/card0 file descriptor.

This PR is related to flatcar/Flatcar#1935 where the driver was introduced.

My specific hardware:
ASUSTeK COMPUTER INC. MINIPC PN50/PN50, BIOS 0626 08/31/2023

04:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Renoir [Radeon Vega Series / Radeon Vega Mobile Series] (rev c1) (prog-if 00 [VGA controller])
	Subsystem: ASUSTeK Computer Inc. Device 87e7
	Flags: bus master, fast devsel, latency 0, IRQ 34, IOMMU group 5
	Memory at d0000000 (64-bit, prefetchable) [size=256M]
	Memory at e0000000 (64-bit, prefetchable) [size=2M]
	I/O ports at e000 [size=256]
	Memory at fe600000 (32-bit, non-prefetchable) [size=512K]
	Capabilities: <access denied>
	Kernel driver in use: amdgpu
	Kernel modules: amdgpu

These changes will enable the compute functionality on all AMD GPUs, not mine specifically.

How to use

load the amdgpu driver and verify the /dev/kfd device is present. Confirm that the gpu is visible with rocminfo.

Testing done

I have built an image and loaded it onto my machine. ROCm info reports the correct info. I feel that it should be noted that

core@host ~ $ uname -a
Linux host.yallywood.com 6.12.87-flatcar #1 SMP PREEMPT_DYNAMIC Fri May 29 02:41:36 -00 2026 x86_64 AMD Ryzen 7 4800U with Radeon Graphics AuthenticAMD GNU/Linux
core@host ~ $ cat /etc/os-release 
NAME="Flatcar Container Linux by Kinvolk"
ID="flatcar"
ID_LIKE="coreos"
VERSION="4694.0.0+2026-05-29-1414"
VERSION_ID="4694.0.0"
BUILD_ID="2026-05-29-1414"
SYSEXT_LEVEL="1.0"
PRETTY_NAME="Flatcar Container Linux by Kinvolk 4694.0.0+2026-05-29-1414"
ANSI_COLOR="38;5;75"
HOME_URL="https://flatcar.org"
BUG_REPORT_URL="https://issues.flatcar.org"
SUPPORT_URL="https://groups.google.com/forum/#!forum/flatcar-linux-user"
FLATCAR_BOARD="amd64-usr"
CPE_NAME="cpe:2.3:o:flatcar-linux:flatcar_linux:4694.0.0+2026-05-29-1414:*:*:*:*:*:*:*"
rocminfo 
 docker exec -it frigate /bin/bash -c '/opt/rocm/bin/rocminfo'
ROCk module is loaded
=====================    
HSA System Attributes    
=====================    
Runtime Version:         1.18
Runtime Ext Version:     1.14
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:  18446744073709551615 (0xFFFFFFFFFFFFFFFF) (timestamp count)
Machine Model:           LARGE                              
System Endianness:       LITTLE                             
Mwaitx:                  DISABLED
XNACK enabled:           YES
DMAbuf Support:          YES
VMM Support:             YES

==========               
HSA Agents               
==========               
*******                  
Agent 1                  
*******                  
  Name:                    AMD Ryzen 7 4800U with Radeon Graphics
  Uuid:                    CPU-XX                             
  Marketing Name:          AMD Ryzen 7 4800U with Radeon Graphics
  Vendor Name:             CPU                                
  Feature:                 None specified                     
  Profile:                 FULL_PROFILE                       
  Float Round Mode:        NEAR                               
  Max Queue Number:        0(0x0)                             
  Queue Min Size:          0(0x0)                             
  Queue Max Size:          0(0x0)                             
  Queue Type:              MULTI                              
  Node:                    0                                  
  Device Type:             CPU                                
  Cache Info:              
    L1:                      32768(0x8000) KB                   
  Chip ID:                 0(0x0)                             
  ASIC Revision:           0(0x0)                             
  Cacheline Size:          64(0x40)                           
  Max Clock Freq. (MHz):   1800                               
  BDFID:                   0                                  
  Internal Node ID:        0                                  
  Compute Unit:            16                                 
  SIMDs per CU:            0                                  
  Shader Engines:          0                                  
  Shader Arrs. per Eng.:   0                                  
  WatchPts on Addr. Ranges:1                                  
  Memory Properties:       
  Features:                None
  Pool Info:               
    Pool 1                   
      Segment:                 GLOBAL; FLAGS: FINE GRAINED        
      Size:                    24514816(0x1761100) KB             
      Allocatable:             TRUE                               
      Alloc Granule:           4KB                                
      Alloc Recommended Granule:4KB                                
      Alloc Alignment:         4KB                                
      Accessible by all:       TRUE                               
    Pool 2                   
      Segment:                 GLOBAL; FLAGS: EXTENDED FINE GRAINED
      Size:                    24514816(0x1761100) KB             
      Allocatable:             TRUE                               
      Alloc Granule:           4KB                                
      Alloc Recommended Granule:4KB                                
      Alloc Alignment:         4KB                                
      Accessible by all:       TRUE                               
    Pool 3                   
      Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
      Size:                    24514816(0x1761100) KB             
      Allocatable:             TRUE                               
      Alloc Granule:           4KB                                
      Alloc Recommended Granule:4KB                                
      Alloc Alignment:         4KB                                
      Accessible by all:       TRUE                               
    Pool 4                   
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED      
      Size:                    24514816(0x1761100) KB             
      Allocatable:             TRUE                               
      Alloc Granule:           4KB                                
      Alloc Recommended Granule:4KB                                
      Alloc Alignment:         4KB                                
      Accessible by all:       TRUE                               
  ISA Info:                
*******                  
Agent 2                  
*******                  
  Name:                    gfx900                             
  Uuid:                    GPU-XX                             
  Marketing Name:          AMD Radeon Graphics                
  Vendor Name:             AMD                                
  Feature:                 KERNEL_DISPATCH                    
  Profile:                 BASE_PROFILE                       
  Float Round Mode:        NEAR                               
  Max Queue Number:        128(0x80)                          
  Queue Min Size:          64(0x40)                           
  Queue Max Size:          131072(0x20000)                    
  Queue Type:              MULTI                              
  Node:                    1                                  
  Device Type:             GPU                                
  Cache Info:              
    L1:                      16(0x10) KB                        
    L2:                      1024(0x400) KB                     
  Chip ID:                 5686(0x1636)                       
  ASIC Revision:           0(0x0)                             
  Cacheline Size:          64(0x40)                           
  Max Clock Freq. (MHz):   1750                               
  BDFID:                   1024                               
  Internal Node ID:        1                                  
  Compute Unit:            8                                  
  SIMDs per CU:            4                                  
  Shader Engines:          1                                  
  Shader Arrs. per Eng.:   1                                  
  WatchPts on Addr. Ranges:4                                  
  Coherent Host Access:    FALSE                              
  Memory Properties:       APU
  Features:                KERNEL_DISPATCH 
  Fast F16 Operation:      TRUE                               
  Wavefront Size:          64(0x40)                           
  Workgroup Max Size:      1024(0x400)                        
  Workgroup Max Size per Dimension:
    x                        1024(0x400)                        
    y                        1024(0x400)                        
    z                        1024(0x400)                        
  Max Waves Per CU:        40(0x28)                           
  Max Work-item Per CU:    2560(0xa00)                        
  Grid Max Size:           4294967295(0xffffffff)             
  Grid Max Size per Dimension:
    x                        2147483647(0x7fffffff)             
    y                        65535(0xffff)                      
    z                        65535(0xffff)                      
  Max fbarriers/Workgrp:   32                                 
  Packet Processor uCode:: 482                                
  SDMA engine uCode::      40                                 
  IOMMU Support::          None                               
  Pool Info:               
    Pool 1                   
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED      
      Size:                    12257408(0xbb0880) KB              
      Allocatable:             TRUE                               
      Alloc Granule:           4KB                                
      Alloc Recommended Granule:2048KB                             
      Alloc Alignment:         4KB                                
      Accessible by all:       FALSE                              
    Pool 2                   
      Segment:                 GLOBAL; FLAGS: EXTENDED FINE GRAINED
      Size:                    12257408(0xbb0880) KB              
      Allocatable:             TRUE                               
      Alloc Granule:           4KB                                
      Alloc Recommended Granule:2048KB                             
      Alloc Alignment:         4KB                                
      Accessible by all:       FALSE                              
    Pool 3                   
      Segment:                 GROUP                              
      Size:                    64(0x40) KB                        
      Allocatable:             FALSE                              
      Alloc Granule:           0KB                                
      Alloc Recommended Granule:0KB                                
      Alloc Alignment:         0KB                                
      Accessible by all:       FALSE                              
  ISA Info:                
    ISA 1                    
      Name:                    amdgcn-amd-amdhsa--gfx900:xnack+   
      Machine Models:          HSA_MACHINE_MODEL_LARGE            
      Profiles:                HSA_PROFILE_BASE                   
      Default Rounding Mode:   NEAR                               
      Default Rounding Mode:   NEAR                               
      Fast f16:                TRUE                               
      Workgroup Max Size:      1024(0x400)                        
      Workgroup Max Size per Dimension:
        x                        1024(0x400)                        
        y                        1024(0x400)                        
        z                        1024(0x400)                        
      Grid Max Size:           4294967295(0xffffffff)             
      Grid Max Size per Dimension:
        x                        2147483647(0x7fffffff)             
        y                        65535(0xffff)                      
        z                        65535(0xffff)                      
      FBarrier Max Size:       32                                 
    ISA 2                    
      Name:                    amdgcn-amd-amdhsa--gfx9-generic:xnack+
      Machine Models:          HSA_MACHINE_MODEL_LARGE            
      Profiles:                HSA_PROFILE_BASE                   
      Default Rounding Mode:   NEAR                               
      Default Rounding Mode:   NEAR                               
      Fast f16:                TRUE                               
      Workgroup Max Size:      1024(0x400)                        
      Workgroup Max Size per Dimension:
        x                        1024(0x400)                        
        y                        1024(0x400)                        
        z                        1024(0x400)                        
      Grid Max Size:           4294967295(0xffffffff)             
      Grid Max Size per Dimension:
        x                        2147483647(0x7fffffff)             
        y                        65535(0xffff)                      
        z                        65535(0xffff)                      
      FBarrier Max Size:       32                                 
*** Done ***
dmesg | grep amdgpu 
core@prb ~ $ dmesg | grep amdgpu
[   18.070083] amdgpu: Virtual CRAT table created for CPU
[   18.071367] amdgpu: Topology: Add CPU node
[   18.072750] amdgpu 0000:04:00.0: enabling device (0006 -> 0007)
[   18.091949] amdgpu 0000:04:00.0: amdgpu: Fetched VBIOS from VFCT
[   18.093023] amdgpu: ATOM BIOS: 113-RENOIR-026
[   18.121633] amdgpu 0000:04:00.0: vgaarb: deactivate vga console
[   18.121735] amdgpu 0000:04:00.0: amdgpu: Trusted Memory Zone (TMZ) feature enabled
[   18.121862] amdgpu 0000:04:00.0: amdgpu: MODE2 reset
[   18.122353] amdgpu 0000:04:00.0: amdgpu: VRAM: 8192M 0x000000F400000000 - 0x000000F5FFFFFFFF (8192M used)
[   18.122535] amdgpu 0000:04:00.0: amdgpu: GART: 1024M 0x0000000000000000 - 0x000000003FFFFFFF
[   18.123685] [drm] amdgpu: 8192M of VRAM memory ready
[   18.123787] [drm] amdgpu: 11970M of GTT memory ready.
[   18.898485] amdgpu 0000:04:00.0: amdgpu: reserve 0x400000 from 0xf5ff800000 for PSP TMR
[   18.986700] amdgpu 0000:04:00.0: amdgpu: RAS: optional ras ta ucode is not available
[   18.996043] amdgpu 0000:04:00.0: amdgpu: RAP: optional rap ta ucode is not available
[   19.000818] amdgpu 0000:04:00.0: amdgpu: psp gfx command LOAD_TA(0x1) failed and response status is (0x7)
[   19.001705] amdgpu 0000:04:00.0: amdgpu: SMU is initialized successfully!
[   19.083359] kfd kfd: amdgpu: Allocated 3969056 bytes on gart
[   19.083487] kfd kfd: amdgpu: Total number of KFD nodes to be created: 1
[   19.083857] amdgpu: Virtual CRAT table created for GPU
[   19.084082] amdgpu: Topology: Add dGPU node [0x1636:0x1002]
[   19.084173] kfd kfd: amdgpu: added device 1002:1636
[   19.084324] amdgpu 0000:04:00.0: amdgpu: SE 1, SH per SE 1, CU per SH 8, active_cu_number 8
[   19.084475] amdgpu 0000:04:00.0: amdgpu: ring gfx uses VM inv eng 0 on hub 0
[   19.084588] amdgpu 0000:04:00.0: amdgpu: ring comp_1.0.0 uses VM inv eng 1 on hub 0
[   19.084709] amdgpu 0000:04:00.0: amdgpu: ring comp_1.1.0 uses VM inv eng 4 on hub 0
[   19.084830] amdgpu 0000:04:00.0: amdgpu: ring comp_1.2.0 uses VM inv eng 5 on hub 0
[   19.084950] amdgpu 0000:04:00.0: amdgpu: ring comp_1.3.0 uses VM inv eng 6 on hub 0
[   19.085071] amdgpu 0000:04:00.0: amdgpu: ring comp_1.0.1 uses VM inv eng 7 on hub 0
[   19.085192] amdgpu 0000:04:00.0: amdgpu: ring comp_1.1.1 uses VM inv eng 8 on hub 0
[   19.085313] amdgpu 0000:04:00.0: amdgpu: ring comp_1.2.1 uses VM inv eng 9 on hub 0
[   19.085433] amdgpu 0000:04:00.0: amdgpu: ring comp_1.3.1 uses VM inv eng 10 on hub 0
[   19.085569] amdgpu 0000:04:00.0: amdgpu: ring kiq_0.2.1.0 uses VM inv eng 11 on hub 0
[   19.085695] amdgpu 0000:04:00.0: amdgpu: ring sdma0 uses VM inv eng 0 on hub 8
[   19.085813] amdgpu 0000:04:00.0: amdgpu: ring vcn_dec uses VM inv eng 1 on hub 8
[   19.085933] amdgpu 0000:04:00.0: amdgpu: ring vcn_enc0 uses VM inv eng 4 on hub 8
[   19.086054] amdgpu 0000:04:00.0: amdgpu: ring vcn_enc1 uses VM inv eng 5 on hub 8
[   19.086175] amdgpu 0000:04:00.0: amdgpu: ring jpeg_dec uses VM inv eng 6 on hub 8
[   19.087914] amdgpu 0000:04:00.0: amdgpu: Runtime PM not available
[   19.089356] [drm] Initialized amdgpu 3.61.0 for 0000:04:00.0 on minor 0
[   19.100479] fbcon: amdgpudrmfb (fb0) is primary device
[   19.176169] amdgpu 0000:04:00.0: [drm] fb0: amdgpudrmfb frame buffer device
zgrep -i amd /proc/config.gz 
core@prb ~ $ zgrep -i amd /proc/config.gz
# CONFIG_X86_AMD_PLATFORM_DEVICE is not set
CONFIG_CPU_SUP_AMD=y
CONFIG_X86_MCE_AMD=y
# CONFIG_PERF_EVENTS_AMD_POWER is not set
CONFIG_PERF_EVENTS_AMD_UNCORE=y
# CONFIG_PERF_EVENTS_AMD_BRS is not set
# CONFIG_AMD_MEM_ENCRYPT is not set
CONFIG_AMD_NUMA=y
CONFIG_X86_AMD_PSTATE=y
CONFIG_X86_AMD_PSTATE_DEFAULT_MODE=3
# CONFIG_X86_AMD_PSTATE_UT is not set
CONFIG_X86_AMD_FREQ_SENSITIVITY=m
CONFIG_AMD_NB=y
CONFIG_KVM_AMD=m
CONFIG_EXTRA_FIRMWARE="intel-ucode/06-cf-02 intel-ucode/06-cf-01 intel-ucode/06-ca-02 intel-ucode/06-c6-04 intel-ucode/06-c6-02 intel-ucode/06-c5-02 intel-ucode/06-bf-07 intel-ucode/06-bf-06 intel-ucode/06-bf-05 intel-ucode/06-bf-02 intel-ucode/06-be-00 intel-ucode/06-bd-01 intel-ucode/06-ba-08 intel-ucode/06-ba-03 intel-ucode/06-ba-02 intel-ucode/06-b7-04 intel-ucode/06-b7-01 intel-ucode/06-b5-00 intel-ucode/06-af-03 intel-ucode/06-ae-01 intel-ucode/06-ad-01 intel-ucode/06-aa-04 intel-ucode/06-a7-01 intel-ucode/06-a6-01 intel-ucode/06-a6-00 intel-ucode/06-a5-05 intel-ucode/06-a5-03 intel-ucode/06-a5-02 intel-ucode/06-9e-0d intel-ucode/06-9e-0c intel-ucode/06-9e-0b intel-ucode/06-9e-0a intel-ucode/06-9e-09 intel-ucode/06-9c-00 intel-ucode/06-9a-04 intel-ucode/06-9a-03 intel-ucode/06-97-05 intel-ucode/06-97-02 intel-ucode/06-96-01 intel-ucode/06-8f-08 intel-ucode/06-8f-07 intel-ucode/06-8f-06 intel-ucode/06-8f-05 intel-ucode/06-8f-04 intel-ucode/06-8e-0c intel-ucode/06-8e-0b intel-ucode/06-8e-0a intel-ucode/06-8e-09 intel-ucode/06-8d-01 intel-ucode/06-8c-02 intel-ucode/06-8c-01 intel-ucode/06-8a-01 intel-ucode/06-7e-05 intel-ucode/06-7a-08 intel-ucode/06-7a-01 intel-ucode/06-6c-01 intel-ucode/06-6a-06 intel-ucode/06-6a-05 intel-ucode/06-66-03 intel-ucode/06-5f-01 intel-ucode/06-5e-03 intel-ucode/06-5c-0a intel-ucode/06-5c-09 intel-ucode/06-5c-02 intel-ucode/06-56-05 intel-ucode/06-56-04 intel-ucode/06-56-03 intel-ucode/06-56-02 intel-ucode/06-55-0b intel-ucode/06-55-07 intel-ucode/06-55-05 intel-ucode/06-55-04 intel-ucode/06-55-03 intel-ucode/06-4e-03 intel-ucode/06-4d-08 intel-ucode/06-4c-04 intel-ucode/06-4c-03 intel-ucode/06-47-01 intel-ucode/06-46-01 intel-ucode/06-45-01 intel-ucode/06-3f-04 intel-ucode/06-3f-02 intel-ucode/06-3e-07 intel-ucode/06-3e-06 intel-ucode/06-3e-04 intel-ucode/06-3d-04 intel-ucode/06-3c-03 intel-ucode/06-3a-09 intel-ucode/06-37-09 intel-ucode/06-37-08 intel-ucode/06-2f-02 intel-ucode/06-2e-06 intel-ucode/06-2d-07 intel-ucode/06-2d-06 intel-ucode/06-2c-02 intel-ucode/06-2a-07 intel-ucode/06-26-01 intel-ucode/06-25-05 intel-ucode/06-25-02 intel-ucode/06-1e-05 intel-ucode/06-1d-01 intel-ucode/06-1c-0a intel-ucode/06-1c-02 intel-ucode/06-1a-05 intel-ucode/06-1a-04 intel-ucode/06-17-0a intel-ucode/06-17-07 intel-ucode/06-17-06 intel-ucode/06-16-01 intel-ucode/06-03-02 intel-ucode/0f-06-08 intel-ucode/0f-06-05 intel-ucode/0f-06-04 intel-ucode/0f-06-02 intel-ucode/0f-04-0a intel-ucode/0f-04-09 intel-ucode/0f-04-08 intel-ucode/0f-04-07 intel-ucode/0f-04-04 intel-ucode/0f-04-03 intel-ucode/0f-04-01 intel-ucode/0f-03-04 intel-ucode/0f-03-03 intel-ucode/0f-03-02 intel-ucode/0f-02-09 intel-ucode/0f-02-07 intel-ucode/0f-02-06 intel-ucode/0f-02-05 intel-ucode/0f-02-04 intel-ucode/0f-01-02 intel-ucode/0f-00-0a intel-ucode/0f-00-07 intel-ucode/06-0f-0d intel-ucode/06-0f-0b intel-ucode/06-0f-0a intel-ucode/06-0f-07 intel-ucode/06-0f-06 intel-ucode/06-0f-02 intel-ucode/06-0e-0c intel-ucode/06-0e-08 intel-ucode/06-0d-06 intel-ucode/06-0b-04 intel-ucode/06-0b-01 intel-ucode/06-0a-01 intel-ucode/06-0a-00 intel-ucode/06-09-05 intel-ucode/06-08-0a intel-ucode/06-08-06 intel-ucode/06-08-03 intel-ucode/06-08-01 intel-ucode/06-07-03 intel-ucode/06-07-02 intel-ucode/06-07-01 intel-ucode/06-06-0d intel-ucode/06-06-0a intel-ucode/06-06-05 intel-ucode/06-06-00 intel-ucode/06-05-03 intel-ucode/06-05-02 intel-ucode/06-05-01 intel-ucode/06-05-00 intel-ucode/.keep_sys-firmware_intel-microcode-0 amd-ucode/microcode_amd_fam1ah.bin amd-ucode/microcode_amd_fam19h.bin amd-ucode/microcode_amd_fam17h.bin amd-ucode/microcode_amd_fam16h.bin amd-ucode/microcode_amd_fam15h.bin amd-ucode/microcode_amd.bin amd-ucode/README "
CONFIG_EXTRA_FIRMWARE_DIR="/build/amd64-usr/lib/firmware"
# CONFIG_PATA_AMD is not set
CONFIG_NET_VENDOR_AMD=y
CONFIG_AMD8111_ETH=m
# CONFIG_AMD_XGBE is not set
CONFIG_AMD_PHY=m
CONFIG_HW_RANDOM_AMD=y
CONFIG_I2C_AMD756=m
# CONFIG_I2C_AMD756_S4882 is not set
CONFIG_I2C_AMD8111=m
# CONFIG_I2C_AMD_MP2 is not set
# CONFIG_PINCTRL_AMD is not set
# CONFIG_GPIO_AMDPT is not set
# CONFIG_GPIO_AMD_FCH is not set
# CONFIG_GPIO_AMD8111 is not set
CONFIG_DRM_AMDGPU=m
# CONFIG_DRM_AMDGPU_SI is not set
# CONFIG_DRM_AMDGPU_CIK is not set
CONFIG_DRM_AMDGPU_USERPTR=y
# CONFIG_DRM_AMD_ISP is not set
# CONFIG_DRM_AMDGPU_WERROR is not set
# CONFIG_DRM_AMD_ACP is not set
CONFIG_DRM_AMD_DC=y
CONFIG_DRM_AMD_DC_FP=y
# CONFIG_DRM_AMD_SECURE_DISPLAY is not set
CONFIG_HSA_AMD=y
CONFIG_HSA_AMD_SVM=y
CONFIG_HSA_AMD_P2P=y
# AMD SFH HID Support
# CONFIG_AMD_SFH_HID is not set
# end of AMD SFH HID Support
CONFIG_USB_PCI_AMD=y
CONFIG_EDAC_AMD64=m
# CONFIG_AMD_QDMA is not set
# CONFIG_AMD_PTDMA is not set
# CONFIG_AMD_PMC is not set
# CONFIG_AMD_HSMP is not set
# CONFIG_AMD_WBRF is not set
CONFIG_AMD_IOMMU=y
CONFIG_AMD_ATL=m
CONFIG_AMD_ATL_PRM=y

I apologize that I don't know how to fill out the other

@mrbojangles3 mrbojangles3 requested a review from a team as a code owner June 1, 2026 01:16
@mrbojangles3 mrbojangles3 deployed to development June 10, 2026 07:32 — with GitHub Actions Active
@ader1990

ader1990 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Hello, can you please update the description with one entry with the exact AMD chipset that you are testing on and what actuall, as it is a bit unclear at a first read on what this PR does (the information is in rocminfo, but a little bit hard to figure out. Also if you can update the PR name with the actual device this PR is trying to fix (if this is targeting dedicated or integrated GPU). I started the workflows and you should be able to consume/test the image from those soon. Thanks!

@mrbojangles3

mrbojangles3 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

I have update the description. Hopefully that is sufficient information, but I am happy to add more.

@ader1990

ader1990 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Thanks for the update - so this refers to only the integrated GPU in the chipset, and not to dedicated AMD GPUs?

Took a look at the image size increase and the changes make sense. The first two changes show that the support has been added to the amdgpu.ko and to the vmlinuz.


Top 10 grown in size files (of 388 files total):

./usr/lib/modules/a.b.c-flatcar/kernel/drivers/gpu/drm/amd/amdgpu/amdgpu.ko.xz by 269628 bytes (263 kbytes) from 3724424 bytes (3637 kbytes, 3 mbytes) to 3994052 bytes (3900 kbytes, 3 mbytes)
./boot/flatcar/vmlinuz-a by 86016 bytes (84 kbytes) from 35703288 bytes (34866 kbytes, 34 mbytes) to 35789304 bytes (34950 kbytes, 34 mbytes)

ader1990
ader1990 approved these changes Jun 10, 2026
View reviewed changes

@ader1990 ader1990 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ader1990

ader1990 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

One thing that is needed, if you can please add a changelog entry, similar to the other kernel ones - specifying for which device you are adding support. You can find one example here: d8c5d9b#diff-8938b0a124b09f76841e97afb21d2e593f8b8d6103b5f86b7a8c6d239bad5527

Thanks.

Add options to enable /dev/kfd on amdgpu
65a9b1a 
Signed-off-by: Logan Blyth <mr.bo.jangles3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ader1990 ader1990 ader1990 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrbojangles3 @ader1990