sys-apps/ignition: Fix giving partition number 0 to get next available#4077
Draft
chewi wants to merge 1 commit into
Draft
sys-apps/ignition: Fix giving partition number 0 to get next available#4077chewi wants to merge 1 commit into
chewi wants to merge 1 commit into
Conversation
chewi
force-pushed
the
chewi/ignition-part-0
branch
from
561fa25 to
b855f78
Compare
This also improves the earlier race condition fix. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
force-pushed
the
chewi/ignition-part-0
branch
from
b855f78 to
b2cd092
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also improves the earlier race condition fix. I have submitted the changes upstream in coreos/ignition#2234, but I have left out the partition deletion change as well as the test changes, since we don't run them.
How to use
I'll attach a Butane config to try this out once it has built.
Testing done
A Jenkins run has...
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.