run_local_tests: Clean up container after listing tests#4083
Open
zhijianli88 wants to merge 1 commit into
Open
run_local_tests: Clean up container after listing tests#4083zhijianli88 wants to merge 1 commit into
zhijianli88 wants to merge 1 commit into
Conversation
The run_local_tests.sh script uses 'docker run' to execute 'kola list' and determine which tests to run. However, without the '--rm' flag, a stopped container instance is left behind after each execution. Running the script multiple times leads to an accumulation of these exited containers, which consumes disk space and clutters the output of 'docker ps -a'. Add the '--rm' flag to the 'docker run' command. This instructs Docker to automatically remove the container when it exits, ensuring no leftover artifacts. Since this container is only used temporarily to list tests, there is no need to preserve it. Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run_local_tests.sh script uses 'docker run' to execute 'kola list' and determine which tests to run. However, without the '--rm' flag, a stopped container instance is left behind after each execution.
Running the script multiple times leads to an accumulation of these exited containers, which consumes disk space and clutters the output of 'docker ps -a'.
Add the '--rm' flag to the 'docker run' command. This instructs Docker to automatically remove the container when it exits, ensuring no leftover artifacts. Since this container is only used temporarily to list tests, there is no need to preserve it.
[Title: describe the change in one sentence]
[ describe the change in 1 - 3 paragraphs ]
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.