Need to run Realm e2e test on 2 GPUs to match mapping#1656
Open
elliottslaughter wants to merge 1 commit into
Open
Need to run Realm e2e test on 2 GPUs to match mapping#1656elliottslaughter wants to merge 1 commit into
elliottslaughter wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1651 unified some code to generate the MPCG for Realm e2e tests. That's fine, but results in the CUDA test assuming 2 GPUs available.
There are two ways to fix this:
For now option (1) seems easier and if we're moving GPU CI to Sapling eventually anyway, having 2 GPUs is a trivial requirement to satisfy.
Makes all tests pass on master.
This change is