Warn about ActiveRecord value column migration#1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ActiveRecord adapter now emits the migration warning when
flipper_gates.valueis still a string column, instead of suppressing it on the first connection check.The guard still marks the warning as handled before checking the column type, so nested connection checks cannot recurse and later reads do not warn repeatedly.
Regression coverage simulates the legacy string column and verifies repeated reads produce exactly one warning.
Validation:
bundle exec rspec spec/flipper/adapters/active_record_spec.rb(159 examples, 0 failures, 2 pending).