Require https for Flipper Cloud url#1016
Open
jnunemaker wants to merge 1 commit into
Open
Conversation
The cloud token is sent on every request via the flipper-cloud-token header, so a non-https url would transmit it in cleartext. Enforce https in Cloud::Configuration#url= and Cloud::Migrate (local dev now uses https via Caddy too), raising ArgumentError otherwise. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flipper Cloud sends the environment token on every request via the
flipper-cloud-tokenheader, so a non-httpsurl would transmit it in cleartext with no warning. This enforceshttpsfor the Cloud url in bothCloud::Configuration#url=(covering options, theFLIPPER_CLOUD_URLenv var, and post-init assignment) andCloud::Migrate(which also sends the token onpush), raisingArgumentErrorotherwise. Local development now runs overhttpsvia Caddy, so the previoushttp://localhostallowance is out of date. Specs were updated to usehttpsand to assert that plainhttpis rejected.🤖 Generated with Claude Code