Return false for type-mismatched comparison operands#1017
Merged
Conversation
Comparison expressions (greater_than, less_than, and their _or_equal_to variants) guarded operands with respond_to?(operator), which confirms both sides respond to >/< but not that they are type-compatible. Since property values commonly arrive as strings from JSON, comparing "25" >= 21 raised ArgumentError out of Feature#enabled?, crashing the whole flag check instead of returning false. Rescue ArgumentError and treat a failed comparison as false, consistent with how missing/nil properties already behave. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparison expressions (
greater_than,less_than, and their_or_equal_tovariants) only guarded operands withrespond_to?(operator), which confirms both sides respond to>/<but not that they're type-compatible. Because property values commonly arrive as strings from JSON, comparing something like"25" >= 21raisedArgumentErrorout ofFeature#enabled?, crashing the entire flag check instead of returning false. This rescuesArgumentErrorinComparable.calland treats a failed comparison asfalse, consistent with how missing/nilproperties already behave. Added specs covering type-mismatched operands (both orderings) for all four comparison expressions.🤖 Generated with Claude Code