Fix race_condition_ttl being a silent no-op in ActiveSupportCacheStore#1018
Merged
Conversation
Line 83 of write_options read the :race_condition_ttl key as a bare expression instead of assigning to it, so the configured value was never passed to the cache. Users setting race_condition_ttl: to guard against cache stampedes got no protection, with no error or warning. Also adds specs asserting the option is passed to the cache when configured and omitted when not. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_optionsread the:race_condition_ttlkey as a bare expression instead of assigning to it, so a configuredrace_condition_ttl:was never passed to the underlying cache. Users setting it to guard against cache stampedes got no protection, with no error or warning. This one-line fix assigns the value, and adds specs asserting the option is passed to the cache when configured and omitted when not.🤖 Generated with Claude Code