Skip to content

refactor(flow-php/telemetry-otlp-bridge): split sync and async curl transports#2482

Merged
norberttech merged 2 commits into
1.xfrom
symfony-messneger-telemtery-tick
Jun 24, 2026
Merged

refactor(flow-php/telemetry-otlp-bridge): split sync and async curl transports#2482
norberttech merged 2 commits into
1.xfrom
symfony-messneger-telemtery-tick

Conversation

@norberttech

Copy link
Copy Markdown
Member

Change Log


Added

  • flow-php/telemetry-otlp-bridge - AsyncCurlTransport (curl_multi) with bounded select-driven tick()
  • flow-php/telemetry-otlp-bridge - otlp_async_curl_transport() and otlp_async_curl_options() DSL helpers
  • flow-php/symfony-telemetry-bundle - transport.type 'async_curl', auto-pumped on WorkerRunningEvent

Fixed

  • flow-php/telemetry-otlp-bridge - CollectorMetrics test parser reads scientific-notation counters

Changed

  • flow-php/telemetry-otlp-bridge - CurlTransport is now synchronous; send() blocks and throws on failure
  • flow-php/telemetry-otlp-bridge - curl request timeout default raised to 10000ms
  • flow-php/symfony-telemetry-bundle - async_curl connect_timeout default 1500ms, pump_timeout 100ms

Removed

Deprecated

Security

…ransports

- CurlTransport now synchronous: send() blocks and throws on failure
- add AsyncCurlTransport (curl_multi) with bounded select-driven tick()
- otlp_async_curl_transport()/otlp_async_curl_options() DSL helpers
- bundle: transport.type 'async_curl', auto-pumped on WorkerRunningEvent
- raise curl request timeout to 10000ms; async connect 1500ms, pump
100ms
- fix CollectorMetrics parser for scientific-notation counters
@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.45320% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.22%. Comparing base (5077649) to head (7dfa9d7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x    #2482      +/-   ##
============================================
+ Coverage     85.19%   85.22%   +0.02%     
- Complexity        0    21561   +21561     
============================================
  Files          1624     1626       +2     
  Lines         66265    66517     +252     
============================================
+ Hits          56457    56691     +234     
- Misses         9808     9826      +18     
Components Coverage Δ
etl 88.45% <ø> (+<0.01%) ⬆️
cli 89.40% <ø> (ø)
lib-array-dot 81.44% <ø> (ø)
lib-azure-sdk 64.44% <ø> (ø)
lib-doctrine-dbal-bulk 93.61% <ø> (ø)
lib-filesystem 85.03% <ø> (ø)
lib-types 90.06% <ø> (ø)
lib-parquet 70.10% <ø> (ø)
lib-parquet-viewer 82.26% <ø> (ø)
lib-snappy 89.38% <ø> (ø)
lib-dremel 0.00% <ø> (ø)
lib-postgresql 88.59% <ø> (ø)
lib-telemetry 86.12% <ø> (ø)
bridge-filesystem-async-aws 92.74% <ø> (ø)
bridge-filesystem-azure 90.45% <ø> (ø)
bridge-monolog-http 96.82% <ø> (ø)
bridge-monolog-telemetry 94.79% <ø> (ø)
bridge-openapi-specification 92.07% <ø> (ø)
symfony-http-foundation 78.57% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr3-telemetry 98.95% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 90.41% <86.58%> (+0.50%) ⬆️
bridge-symfony-http-foundation-telemetry 89.47% <ø> (ø)
bridge-symfony-filesystem-bundle 90.66% <ø> (ø)
bridge-symfony-filesystem-cache 98.18% <ø> (ø)
bridge-symfony-postgresql-bundle 93.07% <ø> (ø)
bridge-symfony-postgresql-cache 94.41% <ø> (ø)
bridge-symfony-postgresql-messenger 98.80% <ø> (ø)
bridge-symfony-postgresql-session 93.65% <ø> (ø)
bridge-symfony-telemetry-bundle 82.35% <85.89%> (+0.07%) ⬆️
adapter-chartjs 84.05% <ø> (ø)
adapter-csv 91.16% <ø> (ø)
adapter-doctrine 90.79% <ø> (ø)
adapter-google-sheet 99.18% <ø> (ø)
adapter-http 72.34% <ø> (ø)
adapter-json 88.63% <ø> (ø)
adapter-logger 50.00% <ø> (ø)
adapter-parquet 77.70% <ø> (ø)
adapter-text 74.13% <ø> (ø)
adapter-xml 83.40% <ø> (ø)
adapter-avro 0.00% <ø> (ø)
adapter-excel 94.21% <ø> (ø)
adapter-postgresql 91.06% <ø> (ø)
adapter-seal 85.42% <ø> (ø)
bridge-phpunit-postgresql 75.30% <ø> (ø)
bridge-phpunit-telemetry 80.29% <ø> (ø)
bridge-phpstan-types 0.00% <ø> (ø)
bridge-postgresql-valinor 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech merged commit a55b612 into 1.x Jun 24, 2026
39 checks passed
@norberttech norberttech deleted the symfony-messneger-telemtery-tick branch June 24, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant