fix: make SimpleRotary double-press backspace reliable

[forntoh]

Summary

• Make SimpleRotaryAdapter use an effective double-press threshold that is reliable with SimpleRotary's 200ms button sampling.
• Keep DOUBLE_PRESS_THRESHOLD=0 behavior for disabling double-press, while clamping positive values below the minimum to avoid missed BACKSPACE actions.
• Document the practical threshold guidance in the rotary examples.

Testing

• pio ci -b esp32dev -l . -O platform=espressif32 -O framework=arduino -O $'lib_deps=\nmarcoschwartz/LiquidCrystal_I2C@^1.1.4\narduino-libraries/LiquidCrystal@^1.0.7\nmprograms/SimpleRotary@^1.1.3\nmadleech/Button@^1.0.0' examples/InputRotary/InputRotary.ino
• pio ci -b esp32dev -l . -O platform=espressif32 -O framework=arduino -O $'lib_deps=\nmarcoschwartz/LiquidCrystal_I2C@^1.1.4\narduino-libraries/LiquidCrystal@^1.0.7\nmprograms/SimpleRotary@^1.1.3\nmadleech/Button@^1.0.0' examples/SimpleRotary/SimpleRotary.ino
• pio ci -b esp32dev -l . -O platform=espressif32 -O framework=arduino -O $'lib_deps=\nmarcoschwartz/LiquidCrystal_I2C@^1.1.4\narduino-libraries/LiquidCrystal@^1.0.7\nmprograms/SimpleRotary@^1.1.3\nmadleech/Button@^1.0.0' examples/ButtonWithRotaryAdapter/ButtonWithRotaryAdapter.ino

Issue

• Closes BACKSPACE not working #376

Summary by CodeRabbit

• Documentation

  • Enhanced comments in example sketches clarifying double-press configuration options and behavior.

• Bug Fixes

  • Enforced minimum double-press timing threshold (500ms) based on button debounce delay for reliable detection; double-press detection can still be disabled by setting DOUBLE_PRESS_THRESHOLD to 0.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 508e17b1-bfd6-4543-9d16-98179063c55b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/376-simple-rotary-backspace

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Memory usage change @ 2f114dd

Board	flash	%	RAM for global variables	%
STMicroelectronics:stm32:GenF1:pnum=BLUEPILL_F103C8	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:avr:uno	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	N/A	N/A	N/A	N/A

Click for full report table

Board	examples/Basic flash	%	examples/Basic RAM for global variables	%	examples/ButtonAdapter flash	%	examples/ButtonAdapter RAM for global variables	%	examples/Callbacks flash	%	examples/Callbacks RAM for global variables	%	examples/InputRotary flash	%	examples/InputRotary RAM for global variables	%	examples/IntFloatValues flash	%	examples/IntFloatValues RAM for global variables	%	examples/KeyboardAdapter flash	%	examples/KeyboardAdapter RAM for global variables	%	examples/List flash	%	examples/List RAM for global variables	%	examples/SimpleRotary flash	%	examples/SimpleRotary RAM for global variables	%	examples/SSD1803A_I2C flash	%	examples/SSD1803A_I2C RAM for global variables	%	examples/UseByRef flash	%	examples/UseByRef RAM for global variables	%	examples/DynamicMenu flash	%	examples/DynamicMenu RAM for global variables	%	examples/Widgets flash	%	examples/Widgets RAM for global variables	%	examples/RTOS flash	%	examples/RTOS RAM for global variables	%
STMicroelectronics:stm32:GenF1:pnum=BLUEPILL_F103C8	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:avr:uno	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp8266:esp8266:huzzah	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Click for full report CSV

Board,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/ButtonAdapter<br>flash,%,examples/ButtonAdapter<br>RAM for global variables,%,examples/Callbacks<br>flash,%,examples/Callbacks<br>RAM for global variables,%,examples/InputRotary<br>flash,%,examples/InputRotary<br>RAM for global variables,%,examples/IntFloatValues<br>flash,%,examples/IntFloatValues<br>RAM for global variables,%,examples/KeyboardAdapter<br>flash,%,examples/KeyboardAdapter<br>RAM for global variables,%,examples/List<br>flash,%,examples/List<br>RAM for global variables,%,examples/SimpleRotary<br>flash,%,examples/SimpleRotary<br>RAM for global variables,%,examples/SSD1803A_I2C<br>flash,%,examples/SSD1803A_I2C<br>RAM for global variables,%,examples/UseByRef<br>flash,%,examples/UseByRef<br>RAM for global variables,%,examples/DynamicMenu<br>flash,%,examples/DynamicMenu<br>RAM for global variables,%,examples/Widgets<br>flash,%,examples/Widgets<br>RAM for global variables,%,examples/RTOS<br>flash,%,examples/RTOS<br>RAM for global variables,%
STMicroelectronics:stm32:GenF1:pnum=BLUEPILL_F103C8,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:avr:uno,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp8266:esp8266:huzzah,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,

[github-actions]

Memory usage change @ 650716b

Board	flash	%	RAM for global variables	%
STMicroelectronics:stm32:GenF1:pnum=BLUEPILL_F103C8	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:avr:uno	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/Basic flash	%	examples/Basic RAM for global variables	%	examples/ButtonAdapter flash	%	examples/ButtonAdapter RAM for global variables	%	examples/Callbacks flash	%	examples/Callbacks RAM for global variables	%	examples/InputRotary flash	%	examples/InputRotary RAM for global variables	%	examples/IntFloatValues flash	%	examples/IntFloatValues RAM for global variables	%	examples/KeyboardAdapter flash	%	examples/KeyboardAdapter RAM for global variables	%	examples/List flash	%	examples/List RAM for global variables	%	examples/SimpleRotary flash	%	examples/SimpleRotary RAM for global variables	%	examples/SSD1803A_I2C flash	%	examples/SSD1803A_I2C RAM for global variables	%	examples/UseByRef flash	%	examples/UseByRef RAM for global variables	%	examples/DynamicMenu flash	%	examples/DynamicMenu RAM for global variables	%	examples/Widgets flash	%	examples/Widgets RAM for global variables	%	examples/RTOS flash	%	examples/RTOS RAM for global variables	%	examples/ST7920_SPI flash	%	examples/ST7920_SPI RAM for global variables	%
STMicroelectronics:stm32:GenF1:pnum=BLUEPILL_F103C8	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:avr:uno	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/ButtonAdapter<br>flash,%,examples/ButtonAdapter<br>RAM for global variables,%,examples/Callbacks<br>flash,%,examples/Callbacks<br>RAM for global variables,%,examples/InputRotary<br>flash,%,examples/InputRotary<br>RAM for global variables,%,examples/IntFloatValues<br>flash,%,examples/IntFloatValues<br>RAM for global variables,%,examples/KeyboardAdapter<br>flash,%,examples/KeyboardAdapter<br>RAM for global variables,%,examples/List<br>flash,%,examples/List<br>RAM for global variables,%,examples/SimpleRotary<br>flash,%,examples/SimpleRotary<br>RAM for global variables,%,examples/SSD1803A_I2C<br>flash,%,examples/SSD1803A_I2C<br>RAM for global variables,%,examples/UseByRef<br>flash,%,examples/UseByRef<br>RAM for global variables,%,examples/DynamicMenu<br>flash,%,examples/DynamicMenu<br>RAM for global variables,%,examples/Widgets<br>flash,%,examples/Widgets<br>RAM for global variables,%,examples/RTOS<br>flash,%,examples/RTOS<br>RAM for global variables,%,examples/ST7920_SPI<br>flash,%,examples/ST7920_SPI<br>RAM for global variables,%
STMicroelectronics:stm32:GenF1:pnum=BLUEPILL_F103C8,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:avr:uno,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.