Fix date parsing crash on newer libc#34
Open
nyanpasu64 wants to merge 2 commits into
Open
Conversation
This reverts commit 3afaee1.
Since newlib commit e5a9f552ecf908f1639b08729edc191c66f4e7d0, setlocale(LC_ALL, null) returns "C/C.UTF-8/C/C/C/C" instead of "C". And libstdc++'s std::locale(char*) cannot parse that locale and throws a runtime_error, which corrupts the call stack resulting in a segfault. To fix this, pass std::locale::classic() directly and skip the setlocale business. And if even this fails, catch the exception and fail the function instead. Is it likely to throw an exception? Probably not. Ideally I'd exit the entire app cleanly (preferably avoiding a game/applet crash) rather than silently swallowing the exception, but I don't know how...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since newlib commit e5a9f552ecf908f1639b08729edc191c66f4e7d0,
setlocale(LC_ALL, null)returns "C/C.UTF-8/C/C/C/C" instead of "C". And libstdc++'sstd::locale(char*)cannot parse that locale and throws a runtime_error, which corrupts the call stack resulting in a segfault.To fix this, pass
std::locale::classic()directly and skip the setlocale business. And if even this fails, catch the exception and fail thefunction instead.
Is it likely to throw an exception? Probably not. Ideally I'd exit the entire app cleanly (preferably avoiding a game/applet crash) rather than silently swallowing the exception, but I don't know how...
std::istringstream+std::get_time, but no workingstrptime?