fix(ipdo): correct ipInRange for IPv6 and high-bit IPv4#5
Open
7c wants to merge 1 commit into
Open
Conversation
ipv6ToBigInt expanded "::" to 9 groups (144 bits) instead of 8 due to an
off-by-one and mishandling of the empty strings produced by split(":").
This corrupted CIDR comparisons, so addresses inside ranges like
2606:4700::/32 and 2000::/3 were reported as out of range.
parseCIDR also computed the IPv4 network with signed 32-bit bitwise ops,
yielding a negative start for addresses >= 128.0.0.0 and breaking ranges
such as 192.168.0.0/24. Switched to arithmetic, which also supports /0.
Fixes funish#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipv6ToBigInt expanded "::" to 9 groups (144 bits) instead of 8 due to an off-by-one and mishandling of the empty strings produced by split(":"). This corrupted CIDR comparisons, so addresses inside ranges like 2606:4700::/32 and 2000::/3 were reported as out of range.
parseCIDR also computed the IPv4 network with signed 32-bit bitwise ops, yielding a negative start for addresses >= 128.0.0.0 and breaking ranges such as 192.168.0.0/24. Switched to arithmetic, which also supports /0.
Fixes #4