fix: add indicator for notifications

[Arukuen]

fixes #57
fixes #58

Summary by CodeRabbit

Release Notes

• New Features

  • Added a rating notice badge to the admin settings menu when cumulative storage savings reach 5MB threshold
  • Users can dismiss the rating notice, with the preference persisting across sessions

• Improvements

  • Admin menu UI updates immediately upon dismissing notifications without requiring a page reload

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e63abb2f-2349-42b4-9373-4d22776de8c9

📥 Commits

Reviewing files that changed from the base of the PR and between 19b4a68 and 8e159f8.

📒 Files selected for processing (4)

• src/admin/class-admin.php
• src/admin/class-metadata.php
• src/admin/class-stats.php
• src/admin/js/page/admin-settings.js

---

📝 Walkthrough

Walkthrough

Adds a RATING_NOTICE_THRESHOLD_BYTES constant and two new methods to Cimo_Stats for cached-only rating-notice evaluation. Stats are now refreshed after instant optimization in Cimo_Metadata. The PHP result is surfaced as a dynamic admin submenu badge and a showRatingNotice JS flag, replacing frontend MB-parsing logic and adding immediate badge removal on dismiss.

Changes

Rating Notice Indicator

Layer / File(s)	Summary
Cimo_Stats threshold and cached rating-notice logic src/admin/class-stats.php	Adds RATING_NOTICE_THRESHOLD_BYTES (5 MB), should_show_rating_notice() (checks cimo_rating_dismissed option and compares cached bytes to threshold), and private get_cached_saved_bytes() (reads OPTION_KEY, clamps KB saved, converts to bytes).
Stats refresh on instant optimization src/admin/class-metadata.php	After writing cimo metadata in add_attachment_metadata(), conditionally calls Cimo_Stats::get_stats() when the class exists, keeping cached stats current after each instant optimization.
Admin submenu badge and JS payload wiring src/admin/class-admin.php	add_admin_menu() conditionally appends an update-plugins HTML badge to the submenu title; enqueue_admin_scripts() computes $show_rating_notice and exposes it as showRatingNotice ('1'/'0') in the cimoAdmin localized JS object.
Frontend flag-driven notice and dismiss cleanup src/admin/js/page/admin-settings.js	Rating notice visibility now depends on window.cimoAdmin?.showRatingNotice === '1' instead of parsing total_storage_saved; handleDismissRating immediately removes .update-plugins indicators from the menu item after dismissal.

Sequence Diagram(s)

sequenceDiagram
    participant Browser as Admin Browser
    participant WPAdmin as WordPress Admin (PHP)
    participant CimoStats as Cimo_Stats
    participant CimoMeta as Cimo_Metadata

    CimoMeta->>CimoStats: get_stats() after saving attachment metadata
    WPAdmin->>CimoStats: should_show_rating_notice()
    CimoStats->>CimoStats: get_cached_saved_bytes() from OPTION_KEY
    CimoStats-->>WPAdmin: bool (threshold met & not dismissed)
    WPAdmin->>WPAdmin: append .update-plugins badge to submenu title
    WPAdmin->>Browser: cimoAdmin.showRatingNotice = '1' | '0'
    Browser->>Browser: render rating notice if showRatingNotice === '1'
    Browser->>WPAdmin: POST dismiss rating setting
    Browser->>Browser: remove .update-plugins from menu item

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• gambitph/Cimo#30: Also modifies Cimo_Admin::add_admin_menu() for the Settings submenu, conditionally controlling visibility via a stealth_mode_enabled check — the same method this PR modifies to add the badge.

Poem

🐇 Hop hop, the stats are tracked anew,
Each optimized image updates the queue.
Five megabytes saved? A badge appears!
Dismiss with a click and the dot disappears.
The rabbit checks cache — no heavy recount,
Just a swift little flag, no extra amount! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix: add indicator for notifications' is vague and generic, using non-descriptive terms that don't clearly convey what the actual changes accomplish.	Consider using a more specific title like 'fix: add rating notification indicator to admin menu' to better describe the primary change.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	All coding requirements from linked issues are met: stats refresh added during metadata saving [#57], rating notice threshold logic implemented [#58], and submenu badge display added when threshold met [#58].
Out of Scope Changes check	✅ Passed	All changes are directly related to implementing the rating notification indicator and stats refresh functionality specified in issues #57 and #58; no out-of-scope changes detected.
Docstring Coverage	✅ Passed	Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/57/58/indicator

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Pull request artifacts

file	commit
pr62-cimo-62-merge.zip	8e159f8