Phase 1+2: Unify capability types + HTTP MCP bridge - #126
Merged
Conversation
- Remove duplicate capabilities/types.rs and capabilities/registry.rs - Import types and registry from data-studio-agent - Replace SourceKind::SqlKit with SourceKind::AppLocal - Update init_registry() call to pass registration function array - Update agent/executor.rs and agent_adapters.rs to use data-studio-agent paths
Introduces an embedded HTTP bridge (axum, port 9121) that exposes the capability system over HTTP for the external data-studio-mcp server. Endpoints: POST /tools — list all agent-tagged capabilities POST /invoke — execute a capability by name with connection resolution GET /health — health check Port auto-fallback via portpicker. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Integrates the MCP bridge into sqlkit's app lifecycle: - Initialize McpServerHandle as managed Tauri state - Read mcp-config.json and auto-start bridge in setup hook - Register get_mcp_status and save_mcp_config Tauri commands Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
- Security: reject Elevated/Destructive capabilities on bridge (403) - Lifecycle: save_mcp_config now stops server when autoStart=false - Stale port file: liveness-test (TCP connect) before reporting running - Write port file BEFORE spawning server to avoid orphaned task - app_version: use real version from package_info() - McpConfig::load: log warning on corrupt/parse error - TOCTOU: remove port_available check, bind directly with fallback Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1: Unified Capability Types (previous commit)
Deleted duplicate types.rs + registry.rs from sqlkit, imports from data-studio-agent.
SqlKit→AppLocal.Phase 2: HTTP MCP Bridge (NEW)
Adds an embedded HTTP bridge (axum,
127.0.0.1:9121) that exposes the capability system to the external TypeScript MCP server.Backend (Rust)
src-tauri/src/mcp_bridge.rsmodule with:POST /tools— list agent-tagged capabilitiesPOST /invoke— execute capability with connection resolutionGET /health— health checkportpicker(default 9121, random if busy){app_data_dir}/mcp-config.json(separate from.store.dat){app_data_dir}/mcp-portfor data-studio-mcp discoveryMcpServerHandlewith graceful shutdown/restartget_mcp_status,save_mcp_configVerification
cargo build— clean