chore(lint): prevent generic isRecord guards - #1272
Merged
Merged
Conversation
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 89.47%. Project has 5473 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.71% 81.78% +0.07%
==========================================
Files 427 427 —
Lines 30036 30042 +6
Branches 19526 19555 +29
==========================================
+ Hits 24544 24569 +25
- Misses 5492 5473 -19
- Partials 2049 2047 -2Generated by Codecov Action |
betegon
marked this pull request as ready for review
July 24, 2026 18:04
Consume the @sentry/api operation and response validator at the HTTP boundary instead of maintaining a broader local schema. Remove the redundant lint-rule contract test because Biome is the enforcement path.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8e598d3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Prevents new generic
isRecordtype guards undersrc/. Existing call sites now use local, shape-specific guards so they state which runtime shape they need.Replay recording segments now keep the object boundary already published by
@sentry/apiinstead of degrading it to a localunknown[][]schema. The formatter still uses small semantic guards for nested RRWeb payloads.Changes
isRecorddeclarationsTest Plan
pnpm exec vitest run test/lib/api/replays.test.ts test/lib/formatters/replay.test.ts— 12 passedpnpm run lintpnpm run typecheckpnpm run check:depspnpm run check:errors— no error-class anti-patterns; existing silent-catch backlog remains advisoryisRecordis rejected and a localhasFileMapguard is accepted