Skip to content

fix(explore): Ensure variadic field and environment flags are arrays #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Draft

fix(explore): Ensure variadic field and environment flags are arrays #1294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/commands/explore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,13 +710,19 @@ export const exploreCommand = buildListCommand("explore", {
);

let dataset = flags.dataset;
const userSuppliedFields = flags.field && flags.field.length > 0;
const rawField = flags.field
? ([] as string[]).concat(flags.field)
: undefined;
const userSuppliedFields = rawField && rawField.length > 0;
let fieldList = [...defaultFieldsForDataset(dataset)];
if (userSuppliedFields) {
fieldList = flags.field;
fieldList = rawField;
}
const timeRange = flags.period;
const environment = parseReplayEnvironmentFilter(flags.environment);
const rawEnvironment = flags.environment
? ([] as string[]).concat(flags.environment)
: undefined;
const environment = parseReplayEnvironmentFilter(rawEnvironment);

// --metric auto mode: resolve metric name → tracemetrics aggregate
if (flags.metric) {
Expand Down
Loading