feat(slack): Send priority changes to the notification channel - #282
feat(slack): Send priority changes to the notification channel#282rgibert wants to merge 6 commits into
Conversation
Currently when incident priority is changed we don't notify the notification channel. This means when priority changes it's only visible to people already in the channel, this isn't always all the people interested in the channel (especially when an incident transitions to P0 or P1).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Replace in-place dict mutations (settings.SLACK["key"] = val) with dict
replacement (settings.SLACK = {**settings.SLACK, "key": val}) so
pytest-django's settings fixture properly restores the original dict
between tests.
Also set mock_slack.post_message.return_value in test_posts_to_feed_channel
since the PR now saves the feed message timestamp to the database.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 45d841b. Configure here.
| description=description, | ||
| ) | ||
| decorate_incident_channel(ctx, _slack_service) | ||
| _decoration = decorate_incident_channel(ctx, _slack_service) |
There was a problem hiding this comment.
Fallback drops feed message timestamp
Low Severity
decorate_incident_channel now returns feed_message_ts, and the normal create path saves it, but the degraded-mode fallback assigns the result to _decoration and ignores it. The feed post still happens with no incident row to store the timestamp, and backfill never recovers it, so later severity changes for those incidents never notify the feed channel.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 45d841b. Configure here.
1 participant
Currently when incident priority is changed we don't notify the notification channel. This means when priority changes it's only visible to people already in the channel, this isn't always all the people interested in the channel (especially when an incident transitions to P0 or P1).