Bump joi and react-redux-firebase#87
Conversation
dependabot
Bot
added
dependencies
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "react-gravatar": "^2.6.3", | ||
| "react-redux": "^5.1.2", | ||
| "react-redux-firebase": "^1.5.1", | ||
| "react-redux-firebase": "^4.0.0", |
There was a problem hiding this comment.
Incompatible react-redux-firebase bump
High Severity
Bumping react-redux-firebase to ^4.0.0 without updating the app leaves Firebase wired the v1 way: reactReduxFirebase store enhancer with a config object, plus pathToJS, dataToJS, orderedToJS, and buildChildList. Those APIs were removed in v2/v3 in favor of an initialized Firebase app and ReactReduxFirebaseProvider, so auth and Realtime Database sync are unlikely to work after install.
Reviewed by Cursor Bugbot for commit 211c8e3. Configure here.
| "react-gravatar": "^2.6.3", | ||
| "react-redux": "^5.1.2", | ||
| "react-redux-firebase": "^1.5.1", | ||
| "react-redux-firebase": "^4.0.0", |
There was a problem hiding this comment.
Node twenty requirement mismatch
Medium Severity
react-redux-firebase 4.0.0 declares engines.node >=20, while this repo pins Node 16.15.1 under volta. Local installs and any CI that respects Volta or engine checks can fail or behave differently than environments on Node 20+.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 211c8e3. Configure here.
Removes [joi](https://github.com/hapijs/joi). It's no longer used after updating ancestor dependency [react-redux-firebase](https://github.com/prescottprue/react-redux-firebase). These dependencies need to be updated together. Removes `joi` Updates `react-redux-firebase` from 1.5.1 to 4.0.0 - [Release notes](https://github.com/prescottprue/react-redux-firebase/releases) - [Changelog](https://github.com/prescottprue/react-redux-firebase/blob/main/CHANGELOG.md) - [Commits](prescottprue/react-redux-firebase@v1.5.1...v4.0.0) --- updated-dependencies: - dependency-name: joi dependency-version: dependency-type: indirect - dependency-name: react-redux-firebase dependency-version: 4.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
211c8e3 to
a945f92
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a945f92. Configure here.
| "promise-polyfill": "^6.0.2", | ||
| "xmlhttprequest": "^1.8.0" | ||
| "node": ">=20" | ||
| }, |
There was a problem hiding this comment.
Node twenty requirement mismatch
Medium Severity
The lockfile records react-redux-firebase@4.0.0 with engines.node >=20, while the repo still pins Volta to Node 16.15.1. Local npm install (including the package’s new prepare script noted in the PR) may fail or behave differently on the pinned Node version.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit a945f92. Configure here.
Removes joi. It's no longer used after updating ancestor dependency react-redux-firebase. These dependencies need to be updated together.
Removes
joiUpdates
react-redux-firebasefrom 1.5.1 to 4.0.0Release notes
Sourced from react-redux-firebase's releases.
... (truncated)
Commits
c213733chore: fix release workflow32f8e0afeat!: modernize toolchain to Node 20+, vitest, and Biome (v4) (#1240)9952215chore: add nvmrc for clear node version6c68d76chore: fix 3 typos "seperate(d)" → "separate(d)" in index.d.ts JSDoc (#1239)befe3b9chore(deps): bump ua-parser-js in /examples/complete/react-native (#1218)6e00f5echore(docs): incorrect link (404) to profileFactory in FAQ (#1173)9041285chore(deps): bump follow-redirects in /examples/complete/simple (#1154)9b94cccchore(deps): bump follow-redirects in /examples/complete/firestore (#1153)3ce963fchore(deps): bump follow-redirects in /examples/complete/typescript (#1152)5fa1838v3.11.0 (#1149)Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.